Double the Donation settings should be reviewed - Githubissues

impress-org / give-double-the-donation

Integration with Double-the-Donation

GNU General Public License v3.0

0 stars 0 forks source link

Double the Donation settings should be reviewed #2

Closed kevinwhoffman closed 4 years ago

kevinwhoffman commented 4 years ago

Details

The Double the Donation settings page should follow the standards set by existing GiveWP plugins so that it is more discoverable and maintainable.

Visuals

The Double the Donation tab is nested under General > Settings, but other add-ons have top-level tabs. It's unclear to me whether this is intentional or not.
This registration form link should probably use a short URL in case we need to update it in the future.
This docs URL does not exist

Acceptance Criteria

[x] The settings tab position is reviewed and moved if necessary.
[x] The registration form link uses a short URL.
[x] The docs URL in the bottom right corner of the settings page is fixed.

mathetos commented 4 years ago

The settings should be on its own Tab -- that's expected behavior for all GiveWP addons so we should conform to that
That should be a docs link, agreed. I can take care of that
That will most likely go to our Announcement article or to the WordPress.org readme to the FAQ section. I think it's important that there is somewhere to point users to no matter what, but our FREE add-ons don't typically have online docs on givewp.com so we'll get a little creative here.