Feature: re-add select a different company option

impress-org / give-double-the-donation

Integration with Double-the-Donation

GNU General Public License v3.0

0 stars 0 forks source link

Feature: re-add select a different company option #22

Closed alaca closed 2 weeks ago

alaca commented 1 month ago

Resolves: GIVE-1084

Description

This PR re-adds the option to select a different company.

Affects

DTD v3 form block.

Visuals

https://github.com/user-attachments/assets/cf6e51a2-f939-4c48-8455-3971cb2c9547

Testing Instructions

Install DTD Create a new v3 form Add DTD block View form on the frontend Select company Select another company

Pre-review Checklist

[x] Self Review of code and UX completed

pauloiankoski commented 1 month ago

@jdghinson could you review the video here? Are you okay with that "jump" in the label once a company is selected or would you rather have labels static, only replacing the input with the text?

jdghinson commented 1 month ago

@pauloiankoski Let's maintain the label size and if possible change the dropdown icon.

alaca commented 3 weeks ago

@pauloiankoski resolved https://github.com/impress-org/give-double-the-donation/pull/22/commits/291e0b3200a1e54629a04fc8812471d6ffeda6e8