search

impress-org / give-double-the-donation

Integration with Double-the-Donation
GNU General Public License v3.0
0 stars 0 forks source link

Double the Donation settings have been reviewed #6

Closed lindseymacmillan closed 3 years ago

lindseymacmillan commented 3 years ago

Resolves #2

Description

This PR addresses a handful of issues related to admin settings for the Double the Donation add-on. Specifically, the PR moves the settings into their own top-level tab, and updates form links.

Affects

This PR affects the double the donation ServiceProvider (where setting pages are loaded) and replaces the SettingsTab class with the SettingsPage class to handle rendering the settings page content.

Visuals

n/a

Pre-review Checklist

Testing Instructions

  1. Check that the Double the Donation settings are in their own tab of the Settings page
  2. Check that the registration form link uses a short url
  3. Check that the docs URL exists
lindseymacmillan commented 3 years ago

@mathetos This PR is ready short of your input on a docs URL and link for the associated blog post or readme file (instead of linking to docs).

JasonTheAdams commented 3 years ago

@henryholtgeerts Apparently you and I were tweaking things at the same time. Hahah! I did clean up a few things. Take a look at 5e3d648 to see what changes I made.