impress-org / givewp-elementor-widgets

Adding all GiveWP shortcodes as Elementor widgets
GNU General Public License v3.0
2 stars 0 forks source link

Give 3.0 compatibility #19

Closed alaca closed 8 months ago

alaca commented 9 months ago

Description

This PR adds compatibility for the new V3 forms. There are some limitations due to how the v3 form are displayed and the Display Style option is not working as other options (this option is saved, but the preview doesn't work in Elementor builder). A note is added when a user selects the v3 form saying that preview is not possible inside the Elementor.

Affects

Give Form widget

Testing Instructions

Install Give Install Elementor Install Give Elementor add-on Create v2 and v3 forms Create a page using Elementor Insert the Donation Form widget and select the form to display

Pre-review Checklist

jonwaldstein commented 8 months ago

@alaca i'm having a hard time seeing what was updated because of the code formatting - could you either give a summary of the specific updates or revert the code file formatting so I can see more clearly?

alaca commented 8 months ago

@jonwaldstein you can hide whitespace changes.

Screen Capture_select-area_20240105162015

jonwaldstein commented 8 months ago

@alaca fancy! can you please add some helpful additions:

  1. @unreleased tags with descriptions to the updated code
  2. image/video screenshots to the PR (will also be helpful for QA)

thanks!

alaca commented 8 months ago

@jonwaldstein Screen Capture_select-area_20240108122411

alaca commented 8 months ago

@jonwaldstein this PR passed QA, can you please do the code review? Thanks!

alaca commented 8 months ago

@jonwaldstein good catch! I bumped the GiveWP_DW_4_Elementor_MIN_GIVE_VERSION to 3.0.0