impress-org / givewp-elementor-widgets

Adding all GiveWP shortcodes as Elementor widgets
GNU General Public License v3.0
2 stars 0 forks source link

Fix: hidden text donation button and non-functional options in the Form Grid widget #22

Closed glaubersilva closed 5 months ago

glaubersilva commented 6 months ago

Resolves GIVE-166 and GIVE-168

Description

The "Show Progress Bar" and the "Show Donation Button > Button Background Color" options in the Form Grid widget only existed in the Elementor, but it doesn't exist in the shortcode or block as you can check in the codebase or the docs: https://givewp.com/documentation/core/shortcodes/give_form_grid/

So, the solution implemented in this PR was to remove these options from the Elementor Form Grid widget as they never existed in fact.

This PR also changed the "Donate Button Text Color" to "green" (like in the Form Grid Block) because before it was using "white" as the default color and was confusing the users cause it was making the text "hidden" on white pages. Also, the "Show Donation Button" option is enabled by default - the same behavior as the Form Grid Block.

Affects

The Form Grid Widget

Visuals

https://www.loom.com/share/e3815bc8e85c4c94a5511cfe317be522?sid=2615076e-aa44-4507-a892-0ce20ba09e68

👆 In the video above I demonstrate the "Show Progress Bar" option only exists in the Elementor settings, but the same approach can be used to check that the "Button Background Color" option only exists in the Elementor settings as well.

Testing Instructions

  1. Add the Form Grid widget to an Elementor page;
  2. The "Show Progress Bar" and "Show Donation Button > Button Background Color" options should not be available anymore;
  3. The "Show Donation Button" option should be enabled and the "Donate Button Text Color" should be green instead of white.

Pre-review Checklist