impress-org / givewp-next-gen

GiveWP 3.0.0 Feature Plugin
https://givewp.com/
GNU General Public License v3.0
10 stars 1 forks source link

Visual form builder should have well configured editor styles methodology #34

Closed DevinWalker closed 2 years ago

DevinWalker commented 2 years ago

Details

A well thought out and structure css methodology is required for the long term health of this project. It seems like we want to go the route of CSS modules with Sass. I'm fine with this, but we should agree on and document how this is to be structured and built out.

Currently, the styles lack any logic in their organization and structure. Looking at the build currently there is 10k lines of CSS - nearly all of it is from the Gutenberg styles we are importing.

Questions:

Additional Context

I've been looking into what Gutenberg provides, for example the "base-styles" package here: https://github.com/WordPress/gutenberg/blob/58c78ec5200a38401281c14186095bced2f6f12a/packages/base-styles/README.md

CSS Modules React Doc: https://create-react-app.dev/docs/adding-a-css-modules-stylesheet/

Acceptance Criteria

kjohnson commented 2 years ago

Resolved by changes introduced in https://github.com/impress-org/givewp-next-gen/pull/32.