Template Registrar should be serializable

impress-org / givewp-next-gen

GiveWP 3.0.0 Feature Plugin

https://givewp.com/

GNU General Public License v3.0

10 stars 1 forks source link

Template Registrar should be serializable #84

Closed kjohnson closed 1 year ago

kjohnson commented 1 year ago

@jonwaldstein we might want consider moving this logic to a serialization method of the registrar itself.

_Originally posted by @kjohnson in https://github.com/impress-org/givewp-next-gen/pull/83#discussion_r1015907456_

Yeah I like that idea. I think we can flatten the array as well since we're specifying ID already.

_Originally posted by @jonwaldstein in https://github.com/impress-org/givewp-next-gen/pull/83#discussion_r1016848830_

kjohnson commented 1 year ago

Closing this as non-urgent. We can refactor when it is necessary.