search

impress-org / givewp-snippet-library

A collection of code snippets to enhance or expand on the free Give WordPress Donation Plugin.
https://givewp.com
140 stars 90 forks source link

New add-cardano-ada-currency.php #132

Closed huths0lo closed 3 years ago

huths0lo commented 3 years ago

Resolves #

Adds Cardano Ada as a currency option

Description

Adds Cardano Ada as a currency option

Affects

Affects the list of available currencies

Visuals

NA

Testing Instructions

Add as a code snippet. Remove the php identifier at the top. Activate snippet. Go in to Give settings, and confirm Cardano Ada is listed as an option

Pre-review Checklist

JasonTheAdams commented 3 years ago

Hi @huths0lo,

Thank you for submitting a PR! Unfortunately, this won't work as intended. Our currency list are Fiat Currencies and are supported by all major payment gateways. Cardano is cryptocurrency, so to show up in the list would require the payment gateways to support it (which they don't), or a new payment gateway which handles it. As such, simply displaying the currency would confuse rather than help users.

You're welcome to add a Payment Gateway via a new plugin which supports this currency, but I'm afraid this doesn't belong in core.

Thank you again for taking the time to do this!

huths0lo commented 3 years ago

Gotcha. I had added it for offline payment use for now. There is a plug-in called Cardano Mercury that works with woocommerce. I know the gentleman who wrote that code. I was going to try to modify it to plug in to Give. I’ll circle back once I am able tp achieve that.

On Tue, Oct 26, 2021 at 8:13 AM Jason Adams @.***> wrote:

Hi @huths0lo https://github.com/huths0lo,

Thank you for submitting a PR! Unfortunately, this won't work as intended. Our currency list are Fiat Currencies https://en.wikipedia.org/wiki/Fiat_money and are supported by all major payment gateways. Cardano is cryptocurrency, so to show up in the list would require the payment gateways to support it (which they don't), or a new payment gateway which handles it. As such, simply displaying the currency would confuse rather than help users.

You're welcome to add a Payment Gateway via a new plugin which supports this currency, but I'm afraid this doesn't belong in core.

Thank you again for taking the time to do this!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/impress-org/givewp-snippet-library/pull/132#issuecomment-952041517, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASZQAMBK42KBS2UTY4XLH2TUI3ATNANCNFSM5GWYV5CQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.