impress-org / givewp-snippet-library

A collection of code snippets to enhance or expand on the free Give WordPress Donation Plugin.
https://givewp.com
140 stars 90 forks source link

Differentiating Snippet Library from Actions/Filters Docs #2

Closed mathetos closed 7 years ago

mathetos commented 8 years ago

We need to have a clear distinction between what goes in the Snippet Library and what goes in our Actions/Filters docs.

I think if it's just a simple implementation of an available filter, it should go on docs. The Snippet Library should instead be for more non-obvious uses of filter/actions.

For example, I just added the minimum donation snippet which just uses the give_checkout_error_checks action. But not in an obvious way, so I think that's great.

But the Custom Donation Total Label really is just an example of exactly the purpose of that filter and should instead be hosted here: https://givewp.com/documentation/developers/filters-explanation-and-usage/

@DevinWalker Agree? Disagree?

DevinWalker commented 8 years ago

The problem I have with: https://givewp.com/documentation/developers/filters-explanation-and-usage/ is it's not under version control and we'll have code in two places. Can we perhaps have it hosted here and embed them on the site?

mathetos commented 8 years ago

Something like this might work for that: http://www.codediesel.com/javascript/easily-embed-a-github-repo-onto-your-site/

mathetos commented 7 years ago

I think we're going to be creating a real Give CODEX eventually, which would resolve this issue completely.

Closing for now.