Closed mathetos closed 7 years ago
The problem I have with: https://givewp.com/documentation/developers/filters-explanation-and-usage/ is it's not under version control and we'll have code in two places. Can we perhaps have it hosted here and embed them on the site?
Something like this might work for that: http://www.codediesel.com/javascript/easily-embed-a-github-repo-onto-your-site/
I think we're going to be creating a real Give CODEX eventually, which would resolve this issue completely.
Closing for now.
We need to have a clear distinction between what goes in the Snippet Library and what goes in our Actions/Filters docs.
I think if it's just a simple implementation of an available filter, it should go on docs. The Snippet Library should instead be for more non-obvious uses of filter/actions.
For example, I just added the minimum donation snippet which just uses the give_checkout_error_checks action. But not in an obvious way, so I think that's great.
But the Custom Donation Total Label really is just an example of exactly the purpose of that filter and should instead be hosted here: https://givewp.com/documentation/developers/filters-explanation-and-usage/
@DevinWalker Agree? Disagree?