feat: make incrementer plugin work when multiple forms are on a page #85

impress-org / givewp-snippet-library

A collection of code snippets to enhance or expand on the free Give WordPress Donation Plugin.

https://givewp.com

140 stars 90 forks source link

Closed mehul0810 closed 6 years ago

mehul0810 commented 6 years ago

This PR resolve #85

I've tested it based on the "How to use" comment in the snippet. So, we're not supporting Currency Switcher in this issue.

kevinwhoffman commented 6 years ago

@Benunc Can you please review the updated snippet and merge into the snippet library if it meets your needs?

Benunc commented 6 years ago

@mehul0810 please create a very short video demonstrating the functionality here. I should have made better acceptance criteria on the issue.

[ ] the snippet works when multiple forms are on a page
[ ] the instructions at the top include the following line: "NOTE: This snippet will not work on a site using Give's Currency Switcher add-on."

mehul0810 commented 6 years ago

@Benunc I've updated the snippet as per the discussion on the call yesterday. Please find the testing video which will help you review the PR. https://www.useloom.com/share/919a41a26932499fa89110b1b6dfe596