Modal popup logic should be simplified and improved - Githubissues

impress-org / givewp-test-data

GiveWP add-on used for generating test data

GNU General Public License v3.0

1 stars 1 forks source link

Modal popup logic should be simplified and improved #13

Closed alaca closed 3 years ago

alaca commented 3 years ago

User Story

As a developer, I want that modal popup API is easy to use and that it has support for the onClose and onConfirm callback options.

Details

Currently, the modal window class doesn't support the onClose callback and the argument structure of GiveModal class is a bit confusing.

Additional Context

Acceptance Criteria

[x] Modal API is relatively easy to use across each page
[x] Modal API supports onClose callback