search

impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.
https://givewp.com/
GNU General Public License v3.0
344 stars 191 forks source link

refactor(donor): create singular method to delete donor #2347

Closed mehul0810 closed 6 years ago

mehul0810 commented 6 years ago

Issue Overview

Currently, there are many different ways used to delete donor. However, to overcome this issue we require a unified function with which donor deletion can be managed and made extensible.

Check Document for more details: https://docs.google.com/document/d/1opVjPivmtxHk-MTSw39WDFma3PgQetoTVRt-4FciB5w/edit#

Expected Behavior

Create an extensible and unique function to manage donor deletion process.

Current Behavior

Managed via multiple functions.

Todos

DevinWalker commented 6 years ago

@mehul0810 can you draft a post on developers.givewp.com and I'll review - then we can close this one out.

mehul0810 commented 6 years ago

Slack Call Summary

Participants: @mehul0810 @ravinderk Topic: Discussion on simplifying the tools section for donor delete Result: It seems that the donor delete process fn missed out for tools section in admin. So, I'll create another function which specifically deletes donors and payments without redirect which will help us unify the process. So, I'll create a new PR to manage this functionality and then will create a detail developers blog post