search

impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.
https://givewp.com/
GNU General Public License v3.0
344 stars 191 forks source link

IMPORTER: Donations are being inaccurately marked as duplicates #2420

Closed mathetos closed 6 years ago

mathetos commented 6 years ago

Issue Overview

Donations are being inaccurately marked as duplicates.

Expected Behavior

When a CSV file is imported, and the donations are from the exact same donor but on different dates, they should all be imported.

Current Behavior

Currently, it appears only the FIRST donation from a donor is imported and all others are treated as duplicates even though the donations occured on different dates.

Possible Solution

I believe these lines here are either malforming or misconstruing the date formats for imported donations: https://github.com/WordImpress/Give/blob/release/1.8.17/includes/import-functions.php#L684-L685

Steps to Reproduce (for bugs)

  1. Ask me for the CSV file I've been working from
  2. Map the fields like so: givewp-mapped-fields
  3. Run the import
  4. You'll get around 129 duplicates when there are only 22 duplicates total.
raftaar1191 commented 6 years ago

https://givewp.slack.com/files/U064V9KDJ/F865UL2JF/pawm-import-edited.csv

https://docs.google.com/a/wordimpress.com/spreadsheets/d/15A9d2yY8UeLBBZ38iSGgiHvr6RQ7K0Hg1_P9NHYiP-c/edit?usp=sharing