search

impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.
https://givewp.com/
GNU General Public License v3.0
344 stars 191 forks source link

[Give 2.0] Donation Goal - Number of donations option does not work as intended always #2607

Closed marutim closed 6 years ago

marutim commented 6 years ago

Issue Overview

I have cloned my current local Give ( v1.8.19 ) setup and have activated Give 2.0. I was testing the "number of donations" option in a existing donation form. The number of donations done is 52 but when I set the number of donations to 60 or 100. I see a Goal achieved message, but when I set the number to 9999 it works fine.

Expected Behavior

The donation form should be available for any number ( number of donations set ( for eg 60 ) ) which is greater than the current number of donations ( for eg 52).

Steps to Reproduce (for bugs)

  1. Go to an existing donation form.
  2. Set the Donation goal "Number of donations" to a higher number like 9999. Then check the front end to see the total number of donations done already ( eg 52)
  3. Now set the number of donation again to 60 or 100 and check the front end.
  4. Now you will see the Goal achieved message.

Screenshots

1 2 3 4

WordPress Environment

``` ### WordPress Environment ### Home URL: http://give-2-0.local Site URL: http://give-2-0.local WP Version: 4.9.1 WP Multisite: – WP Memory Limit: 256 MB WP Debug Mode: ✔ WP Cron: ✔ Language: en_US Permalink Structure: /%postname%/ Show on Front: posts Table Prefix Length: 3 Table Prefix Status: Acceptable Admin AJAX: Inaccessible Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, refunded, failed, revoked, cancelled, abandoned, processing, preapproval, give_subscription ### Server Environment ### Hosting Provider: DBH: localhost, SRV: give-2-0.local TLS Connection: Connection uses TLS 1.2 TLS Connection: Probably Okay Server Info: Flywheel/4.1.0 PHP Version: 5.6.20 PHP Post Max Size: 1,000 MB PHP Time Limit: 300 PHP Max Input Vars: 4000 PHP Max Upload Size: 300 MB cURL Version: ❌ 7.38.0, OpenSSL/1.0.2k - We recommend a minimum cURL version of 7.40. SUHOSIN Installed: – MySQL Version: 5.6.36 Default Timezone is UTC: ✔ fsockopen/cURL: ✔ SoapClient: ✔ DOMDocument: ✔ gzip: ✔ GD Graphics Library: ✔ Multibyte String: ✔ Remote Post: ✔ Remote Get: ✔ ### Give Configuration ### Give Version: 2.0.0 Give Cache: Enabled Database Updates: All DB Updates Completed. Give Cache: Enabled Give Cache: ✔New Donation✔Donation Receipt✔New Offline Donation✔Offline Donation Instruction✔New Donor Register✔Donor Register✔Email access Upgraded From: 1.8.19 Test Mode: Enabled Currency Code: USD Currency Position: Before Decimal Separator: . Thousands Separator: , Success Page: http://give-2-0.local/donation-confirmation/ Failure Page: http://give-2-0.local/donation-failed/ Donation History Page: http://give-2-0.local/donation-history/ Give Forms Slug: /donations/ Enabled Payment Gateways: Offline Donation, Test Donation, Authorize.net, Stripe - Credit Card Default Payment Gateway: Test Donation PayPal IPN Verification: Enabled PayPal IPN Notifications: N/A Admin Email Notifications: Disabled Donor Email Access: Enabled ### Session Configuration ### Give Use Sessions: Enabled Session: Disabled ### Active Give Add-ons ### Give - Authorize.net Gateway: ❌ Unlicensed – by WordImpress – 1.3.2 Give - Donation Plugin: ❌ Unlicensed – by WordImpress – 2.0.0 Give - Fee Recovery: ❌ Unlicensed – by WordImpress – 1.3.7 Give - Form Field Manager: ❌ Unlicensed – by WordImpress – 1.2.4 Give - MailChimp: ❌ Unlicensed – by WordImpress – 1.3.6 Give - Manual Donations: ❌ Unlicensed – by WordImpress – 1.2.1 Give - PayPal Pro Gateway: ❌ Unlicensed – by WordImpress – 1.1.4 Give - PDF Receipts: ❌ Unlicensed – by WordImpress – 2.2.2 Give - Recurring Donations: ❌ Unlicensed – by WordImpress – 1.5.2 Give - Stripe Gateway: ❌ Unlicensed – by WordImpress – 1.5.2 Give - Tributes: ❌ Unlicensed – by WordImpress – 1.3.3 ### Other Active Plugins ### Debug Bar: by wordpressdotorg – 0.9 Debug Bar Post Meta: by whyisjake – 0.5.4 Email Cop: by Ashfame – 0.1.1 Give - Hook Helper: by Ravinder Kumar – 1.0 ### Inactive Plugins ### Automatic Responsive Tables: by Andrew Rockwell – 1.2 Duplicate Post: by Enrico Battocchi – 3.2.1 Give - AmeriCloud Payments: by AmeriCloud Solutions, Inc. – 1.2.0 Give - Braintree Gateway: by WordImpress – 1.1.1 Give - CCAvenue Gateway: by WordImpress – 1.0 Give - Constant Contact: by WordImpress – 1.2.1 Give - ConvertKit: by WordImpress – 1.0.1 Give - CSV Toolbox: by WordImpress – 1.0 Give - Email Reports: by WordImpress – 1.0.2 Give - GoCardless Gateway: by WordImpress – 1.1 Give - Google Analytics Donation Tracking: by WordImpress – 1.1 Give - In Honor Of Custom Fields: by WordImpress – 1.0 Give - Per Form Emails: by WordImpress – 1.0.2 Give - Per Form Gateways: by WordImpress – 1.0.1 Give - Per Form User Role Assigner: by Matt Cromwell – 1.0 Give - Zapier: by WordImpress – 1.1.2 My Custom Functions: by Arthur Gareginyan – 4.12 WP Filters Extras: by BeAPI – 1.0.2 ### Active MU Plugins ### Local by Flywheel Relative URL (for Live Links): by Flywheel – 1.0 ### Theme ### Name: Twenty Seventeen Version: 1.4 Author URL: https://wordpress.org/ Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme ```
mehul0810 commented 6 years ago

@marutim I'm able to reproduce this issue. Fixing it.

DevinWalker commented 6 years ago

Nice catch @marutim - thanks for fixing fast @mehul0810