impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.
https://givewp.com/
GNU General Public License v3.0
344 stars 191 forks source link

fix(db-update): ensure emails are maintained after 2.0 update #2672

Closed marutim closed 6 years ago

marutim commented 6 years ago

Issue Overview

After updating give to 2.0, the list of emails ( other than the primary email ) and address is removed. Check the screenshot attached for reference.

PS: I did not see an Give 2.0 update in my dashboard, so I manually updated it by deactivating and then deleting Give 1.8.19 and then uploading and activating Give 2.0. I have completed the DB updates too before finding this above behaviour.

PSS: I have cloned by local setup before updating give to 2.0, so I have the older setup with me as well.

Screenshots

1 2

WordPress Environment

With 1.8.19

### WordPress Environment ### Home URL: http://give-1-8-19.local Site URL: http://give-1-8-19.local WP Version: 4.9.2 WP Multisite: – WP Memory Limit: 256 MB WP Debug Mode: ✔ WP Cron: ✔ Language: en_US Permalink Structure: /%postname%/ Show on Front: posts Table Prefix Length: 3 Table Prefix Status: Acceptable Admin AJAX: Inaccessible Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, refunded, failed, revoked, cancelled, abandoned, processing, preapproval, give_subscription ### Server Environment ### Hosting Provider: DBH: localhost, SRV: give-1-8-19.local TLS Connection: Connection uses TLS 1.2 TLS Connection: Probably Okay Server Info: Flywheel/4.1.0 PHP Version: 5.6.20 PHP Post Max Size: 1,000 MB PHP Time Limit: 300 PHP Max Input Vars: 4000 PHP Max Upload Size: 300 MB cURL Version: ❌ 7.38.0, OpenSSL/1.0.2k - We recommend a minimum cURL version of 7.40. SUHOSIN Installed: – MySQL Version: 5.6.36 Default Timezone is UTC: ✔ fsockopen/cURL: ✔ SoapClient: ✔ DOMDocument: ✔ gzip: ✔ GD Graphics Library: ✔ Multibyte String: ✔ Remote Post: ✔ Remote Get: ✔ ### Give Configuration ### Give Version: 1.8.19 Database Updates: All DB Updates Completed. Upgraded From: 1.8.18 Test Mode: Enabled Currency Code: USD Currency Position: Before Decimal Separator: . Thousands Separator: , Success Page: http://give-1-8-19.local/donation-confirmation/ Failure Page: http://give-1-8-19.local/donation-failed/ Donation History Page: http://give-1-8-19.local/donation-history/ Give Forms Slug: /donations/ Enabled Payment Gateways: Offline Donation, Test Donation, Authorize.net, Stripe - Credit Card Default Payment Gateway: Test Donation PayPal IPN Verification: Enabled PayPal IPN Notifications: N/A Admin Email Notifications: Enabled Donor Email Access: Enabled ### Session Configuration ### Give Use Sessions: Enabled Session: Disabled ### Active Give Add-ons ### Give - Authorize.net Gateway: ❌ Unlicensed – by WordImpress – 1.3.3 Give - CCAvenue Gateway: ❌ Unlicensed – by WordImpress – 1.0 Give - Fee Recovery: ❌ Unlicensed – by WordImpress – 1.3.8 Give - Form Field Manager: ❌ Unlicensed – by WordImpress – 1.2.4 Give - GoCardless Gateway: ❌ Unlicensed – by WordImpress – 1.1.1 Give - Google Analytics Donation Tracking: ❌ Unlicensed – by WordImpress – 1.1.1 Give - Manual Donations: ❌ Unlicensed – by WordImpress – 1.2.2 Give - PayPal Pro Gateway: ❌ Unlicensed – by WordImpress – 1.1.4 Give - PDF Receipts: ❌ Unlicensed – by WordImpress – 2.2.3 Give - Recurring Donations: ❌ Unlicensed – by WordImpress – 1.5.4 Give - Stripe Gateway: ❌ Unlicensed – by WordImpress – 1.5.2 Give - Tributes: ❌ Unlicensed – by WordImpress – 1.3.4 ### Other Active Plugins ### Debug Bar: by wordpressdotorg – 0.9 Debug Bar Post Meta: by whyisjake – 0.5.4 Duplicate Post: by Enrico Battocchi – 3.2.1 Email Cop: by Ashfame – 0.1.1 Give - Hook Helper: by Ravinder Kumar – 1.0 ### Inactive Plugins ### Automatic Responsive Tables: by Andrew Rockwell – 1.2 Give - AmeriCloud Payments: by AmeriCloud Solutions, Inc. – 1.2.0 Give - Braintree Gateway: by WordImpress – 1.1.1 Give - Constant Contact: by WordImpress – 1.2.1 Give - ConvertKit: by WordImpress – 1.0.1 Give - CSV Toolbox: by WordImpress – 1.0 Give - Email Reports: by WordImpress – 1.0.2 Give - In Honor Of Custom Fields: by WordImpress – 1.0 Give - MailChimp: by WordImpress – 1.3.6 Give - Per Form Emails: by WordImpress – 1.0.2 Give - Per Form Gateways: by WordImpress – 1.0.1 Give - Per Form User Role Assigner: by Matt Cromwell – 1.0 Give - Zapier: by WordImpress – 1.1.2 My Custom Functions: by Arthur Gareginyan – 4.12 WP Filters Extras: by BeAPI – 1.0.2 ### Active MU Plugins ### Local by Flywheel Relative URL (for Live Links): by Flywheel – 1.0 ### Theme ### Name: Twenty Seventeen Version: 1.4 Author URL: https://wordpress.org/ Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

With 2.0

### WordPress Environment ### Home URL: http://wp-give.test Site URL: http://wp-give.test WP Version: 4.9.2 WP Multisite: – WP Memory Limit: 256 MB WP Debug Mode: ✔ WP Cron: ✔ Language: en_US Permalink Structure: /%postname%/ Show on Front: posts Table Prefix Length: 3 Table Prefix Status: Acceptable Admin AJAX: Accessible Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, refunded, failed, revoked, cancelled, abandoned, processing, preapproval, give_subscription ### Server Environment ### Hosting Provider: DBH: localhost, SRV: wp-give.test TLS Connection: Connection uses TLS 1.2 TLS Connection: Probably Okay Server Info: Flywheel/4.1.0 PHP Version: 5.6.20 PHP Post Max Size: 1,000 MB PHP Time Limit: 300 PHP Max Input Vars: 4000 PHP Max Upload Size: 300 MB cURL Version: ❌ 7.38.0, OpenSSL/1.0.2k - We recommend a minimum cURL version of 7.40. SUHOSIN Installed: – MySQL Version: 5.6.36 Default Timezone is UTC: ✔ fsockopen/cURL: ✔ SoapClient: ✔ DOMDocument: ✔ gzip: ✔ GD Graphics Library: ✔ Multibyte String: ✔ Remote Post: ✔ Remote Get: ✔ ### Give Configuration ### Give Version: 2.0.0 Give Cache: Enabled Database Updates: All DB Updates Completed. Give Cache: Enabled Give Cache: ✔New Donation✔Donation Receipt✔New Offline Donation✔Offline Donation Instructions✔New User Registration✔User Registration Information✔Email access Upgraded From: 1.8.19 Test Mode: Enabled Currency Code: USD Currency Position: Before Decimal Separator: . Thousands Separator: , Success Page: http://wp-give.test/donation-confirmation/ Failure Page: http://wp-give.test/donation-failed/ Donation History Page: http://wp-give.test/donation-history/ Give Forms Slug: /donations/ Enabled Payment Gateways: Offline Donation, Test Donation, Stripe - Credit Card Default Payment Gateway: Test Donation PayPal IPN Verification: Enabled PayPal IPN Notifications: N/A Donor Email Access: Enabled ### Session Configuration ### Give Use Sessions: Enabled Session: Disabled ### Active Give Add-ons ### Give - Fee Recovery: ❌ Unlicensed – by WordImpress – 1.3.8 Give - Form Field Manager: ❌ Unlicensed – by WordImpress – 1.2.4 Give - Manual Donations: ❌ Unlicensed – by WordImpress – 1.2.2 Give - PayPal Pro Gateway: ❌ Unlicensed – by WordImpress – 1.1.4 Give - PDF Receipts: ❌ Unlicensed – by WordImpress – 2.2.3 Give - Recurring Donations: ❌ Unlicensed – by WordImpress – 1.5.4 Give - Stripe Gateway: ❌ Unlicensed – by WordImpress – 1.5.2 Give - Tributes: ❌ Unlicensed – by WordImpress – 1.3.4 Give - Zapier: ❌ Unlicensed – by WordImpress – 1.1.2 ### Other Active Plugins ### Debug Bar: by wordpressdotorg – 0.9 Debug Bar Post Meta: by whyisjake – 0.5.4 Duplicate Post: by Enrico Battocchi – 3.2.1 Email Cop: by Ashfame – 0.1.1 Give - Hook Helper: by Ravinder Kumar – 1.0 ### Inactive Plugins ### Automatic Responsive Tables: by Andrew Rockwell – 1.2 Give - AmeriCloud Payments: by AmeriCloud Solutions, Inc. – 1.2.0 Give - Authorize.net Gateway: by WordImpress – 1.3.3 Give - Braintree Gateway: by WordImpress – 1.1.1 Give - CCAvenue Gateway: by WordImpress – 1.0 Give - Constant Contact: by WordImpress – 1.2.1 Give - ConvertKit: by WordImpress – 1.0.1 Give - CSV Toolbox: by WordImpress – 1.0 Give - Email Reports: by WordImpress – 1.0.2 Give - GoCardless Gateway: by WordImpress – 1.1.1 Give - Google Analytics Donation Tracking: by WordImpress – 1.1.1 Give - MailChimp: by WordImpress – 1.3.6 Give - Per Form Emails: by WordImpress – 1.0.2 Give - Per Form Gateways: by WordImpress – 1.0.1 Give - Per Form User Role Assigner: by Matt Cromwell – 1.0 My Custom Functions: by Arthur Gareginyan – 4.12 WP Filters Extras: by BeAPI – 1.0.2 ### Active MU Plugins ### Local by Flywheel Relative URL (for Live Links): by Flywheel – 1.0 ### Theme ### Name: Twenty Seventeen Version: 1.4 Author URL: https://wordpress.org/ Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme
raftaar1191 commented 6 years ago

@marutim I try to reproduce this issues at my ends but it's working fine. Can you please share you DB dump so that we can reverify this issues

marutim commented 6 years ago

@raftaar1191 I have shared the flywheel site exported file n and DB dump to @ravinderk in the evenung. Can you please check with him please. Thanks

raftaar1191 commented 6 years ago

Thanks, @marutim I got the zip from @ravinderk

I just tested this out and it's working fine Here is the video that I create when testing this out: https://screencast-o-matic.com/watch/cFVFYaoFC7

ravinderk commented 6 years ago

@marutim Closing this issue because we did not hear about it much and also @raftaar1191 unable to reproduce this.