impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.
https://givewp.com/
GNU General Public License v3.0
344 stars 191 forks source link

fix(donation): invalid donation amount error at the the of donating #3372

Closed raftaar1191 closed 6 years ago

raftaar1191 commented 6 years ago

User Story

As an Admin, I do not want my donor should get any type of notice about the invalid donation amount

Current Behavior

I currently getting invalid donation amount notices

Expected Behavior

I expect to work as normal as it used to work in Give Core 2.1.4

Steps to Reproduce

Check the Video

Visuals

Video Link: https://screencast-o-matic.com/watch/cF12DJFiMJ

image

Environment

WordPress System Info ### WordPress Environment ### Home URL: http://givewp.local Site URL: http://givewp.local WP Version: 4.9.6 WP Multisite: – WP Memory Limit: 256 MB WP Debug Mode: ✔ WP Cron: ✔ Language: en_US Permalink Structure: /%year%/%monthnum%/%day%/%postname%/ Show on Front: posts Table Prefix Length: wp_ Table Prefix Length: 3 Table Prefix Status: Acceptable Admin AJAX: Accessible Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, refunded, failed, revoked, cancelled, abandoned, processing, preapproval, give_subscription ### Server Environment ### Hosting Provider: DBH: localhost, SRV: givewp.local TLS Connection: Connection uses TLS 1.2 TLS Connection: Probably Okay Server Info: Apache/2.4.10 (Debian) PHP Version: 7.1.4 PHP Post Max Size: 1,000 MB PHP Time Limit: 900 PHP Max Input Vars: 3000 PHP Max Upload Size: 1,000 MB cURL Version: ❌ 7.38.0, OpenSSL/1.0.1t - We recommend a minimum cURL version of 7.40. SUHOSIN Installed: – MySQL Version: ❌ 5.5.55 - We recommend a minimum MySQL version of 5.6. See: WordPress Requirements Default Timezone is UTC: ✔ fsockopen/cURL: ✔ SoapClient: ✔ DOMDocument: ✔ gzip: ✔ GD Graphics Library: ✔ Multibyte String: ✔ Remote Post: ✔ Remote Get: ✔ ### Give Configuration ### Give Version: 2.1.4 Give Cache: Enabled Database Updates: All DB Updates Completed. Give Cache: Enabled Give Cache: ✔New Donation✔Donation Receipt✔New Offline Donation✔Offline Donation Instructions✔New User Registration✔User Registration Information✔Email access❌Daily Email Report❌Weekly Email Report❌Monthly Email Report❌Renewal Receipt Email❌Subscription Cancelled Email Upgraded From: – Test Mode: Enabled Currency Code: GBP Currency Position: Before Decimal Separator: . Thousands Separator: , Success Page: http://givewp.local/donation-confirmation/ Failure Page: http://givewp.local/donation-failed/ Donation History Page: http://givewp.local/donation-history/ Give Forms Slug: /donations/ Enabled Payment Gateways: Test Donation, Offline Donation Default Payment Gateway: Test Donation PayPal IPN Verification: Enabled PayPal IPN Notifications: N/A Donor Email Access: Enabled ### Session Configuration ### Give Use Sessions: Enabled Session: Disabled ### Active Give Add-ons ### Give - 2Checkout Gateway: ❌ Unlicensed – by WordImpress – 1.1 Give - Authorize.net Gateway: ❌ Unlicensed – by WordImpress – 1.3.3 Give - AWeber: ❌ Unlicensed – by WordImpress – 1.0.2 Give - Braintree Gateway: ❌ Unlicensed – by WordImpress – 1.2 Give - CCAvenue Gateway: ❌ Unlicensed – by WordImpress – 1.0.1 Give - Constant Contact: ❌ Unlicensed – by WordImpress – 1.2.1 Give - ConvertKit: ❌ Unlicensed – by WordImpress – 1.0.1 Give - Currency Switcher: ❌ Unlicensed – by WordImpress – 1.2 Give - Display Donors: ❌ Unlicensed – by WordImpress, LLC – 1.0 Give - Email Reports: ❌ Unlicensed – by WordImpress – 1.1.1 Give - Form Countdown: ❌ Unlicensed – by WordImpress – 1.0 Give - Form Field Manager: ❌ Unlicensed – by WordImpress – 1.3 Give - Gift Aid: ❌ Unlicensed – by WordImpress – 1.1.1 Give - Google Analytics Donation Tracking: ❌ Unlicensed – by WordImpress – 1.1.4 Give - MailChimp: ❌ Unlicensed – by WordImpress – 1.4 Give - Manual Donations: ❌ Unlicensed – by WordImpress – 1.3.1 Give - Paymill Gateway: ❌ Unlicensed – by WordImpress – 1.1 Give - PayPal Pro Gateway: ❌ Unlicensed – by WordImpress – 1.1.4 Give - PDF Receipts: ❌ Unlicensed – by WordImpress – 2.2.5 Give - Razorpay: ❌ Unlicensed – by WordImpress – 1.1.4 Give - Recurring Donations: ❌ Unlicensed – by WordImpress – 1.6.2 Give - Zapier: ❌ Unlicensed – by WordImpress – 1.1.2 ### Other Active Plugins ### ### Inactive Plugins ### BuddyPress: by The BuddyPress Community – 3.0.0 Caldera Forms: by Caldera Labs – 1.5.9.1 Charitable: by WP Charitable – 1.6.1 Debug Bar: by wordpressdotorg – 0.9 Debug Bar Console: by koopersmith – 0.3 Debug Bar Cron: by Zack Tollman, Helen Hou-Sandi – 0.1.2 Debug Bar Extender: by Thorsten Ott, Automattic – 0.5 Developer: by Automattic – 1.2.6 Duplicate Post: by Enrico Battocchi – 3.2.2 Email Cop: by Ashfame – 0.1.1 Give - Development Plugin: by Raftaar1191 – 1.0.0 Give - Dwolla Gateway: by WordImpress – 1.1.2 Give - Fee Recovery: by WordImpress – 1.6.1 Give - Stripe Gateway: by WordImpress – 2.0.5 Give - Tributes: by WordImpress – 1.4.2 Gravity Forms: by rocketgenius – 2.2.6 Gravity Forms Signature Add-On: by Rocketgenius – 3.4 Loco Translate: by Tim Whitlock – 2.1.4 Log Deprecated Notices: by Andrew Nacin – 0.4 Log Viewer: by Markus Fischbacher – 14.05.04 Monster Widget: by Automattic – 0.3 Polylang: by Frédéric Demarle – 2.3.6 qTranslate-X: by qTranslate Team – 3.4.6.8 Query Monitor: by John Blackbourn & contributors – 3.0.1 Rewrite Rules Inspector: by Daniel Bachhuber, Automattic – 1.2.1 User Switching: by John Blackbourn & contributors – 1.3.1 WooCommerce: by Automattic – 3.4.1 WordPress Beta Tester: by Peter Westwood – 1.2.2 WP Hide & Security Enhancer: by Nsp Code – 1.4.9.1 WPML Multilingual CMS: by OnTheGoSystems – 3.9.4 WPS Hide Login: by WPServeur, NicolasKulka, tabrisrp – 1.3.4.2 ### Active MU Plugins ### Local by Flywheel Relative URL (for Live Links): by Flywheel – 1.0 ### Theme ### Name: Twenty Seventeen Version: 1.6 Author URL: https://wordpress.org/ Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme
ravinderk commented 6 years ago

@raftaar1191 I recently update logic for validate donation amount: https://github.com/ravinderk/Give/commit/41d849235a1cfec998e9535051aaf899106968ad

With currency switcher, somehow currency is not changing because of is_admin on ajax: https://github.com/WordImpress/Give-Currency-Switcher/blob/master/includes/frontend/class-give-currency-switcher-frontend.php#L91

We need @emgk help to review this.