impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.
https://givewp.com/
GNU General Public License v3.0
340 stars 191 forks source link

feat(admin-plugins): do not deactivate the add-on if the PHP or Give Core minimum version does not match #3440

Closed raftaar1191 closed 6 years ago

raftaar1191 commented 6 years ago

User Story

As an Admin I do not like it when Core deactivates add-ons automatically.

It should be activated and should show me a message that you need to update to Give Core Version 2.1.7 to use this add-on.

Video displaying issue: https://screencast-o-matic.com/watch/cFi1lwFvSb

Current Behavior

I currently see add-on is getting deactivate if Give Core Minimum version or PHP minimum version is not match

Expected Behavior

I expect to show display an Admin notices to update the Give Core or PHP version

Add-ons Updated to Not Deactivate if Requirement Not Met

The following add-ons have been updated to not deactivate but rather disable themselves until the Give Core version requirement is met.

... @raftaar1191 will update with a complete list of add-ons.

raftaar1191 commented 6 years ago

@kevinwhoffman what's your suggestion on this

DevinWalker commented 6 years ago

@raftaar1191 yeah I agree it shouldn't deactivate the add-on but rather leave it activated but disabled until the core requirement is met.

Activation Error: Please update Give core to version 2.1.7+ to use the Add-on Name add-on.

raftaar1191 commented 6 years ago

Slack Chat Link: https://givewp.slack.com/archives/D6NDNRU75/p1531265020000080

raftaar1191 commented 6 years ago

Notes

We need to consider the scenario where the activation hook is getting fire in the Add-on

kevinwhoffman commented 6 years ago

As discussed on dev team call, @raftaar1191 estimates another 8-10 hours to complete updates of the remaining add-ons.

raftaar1191 commented 6 years ago

This issue is being fixed have sent the PR of this in all the Add-on. So closing this issue for now if found any bug then please reopen this issue