search

impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.
https://givewp.com/
GNU General Public License v3.0
339 stars 191 forks source link

fix: delete form meta when we delete the donation form #3641

Closed raftaar1191 closed 5 years ago

raftaar1191 commented 6 years ago

User Story

As an Admin I want that the form meta should get deleted when I delete the donation form permanently.

Current Behavior

I currently can see that the form meta is not getting deleted when donation form is getting deleted

Expected Behavior

I expect form meta must also get deleted when deleting donation form

Steps to Reproduce

Check the video

Visuals

Video Link: https://screencast-o-matic.com/watch/cFjvXhqw8h

image

Environment

WordPress System Info ### WordPress Environment ### Home URL: https://givewp.local Site URL: https://givewp.local WP Version: 4.9.8 WP Multisite: – WP Memory Limit: 256 MB WP Debug Mode: ✔ WP Cron: ✔ Language: en_US Permalink Structure: /%postname%/ Show on Front: posts Table Prefix Length: wp_ Table Prefix Length: 3 Table Prefix Status: Acceptable Admin AJAX: Inaccessible Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, refunded, failed, revoked, cancelled, abandoned, processing, preapproval ### Server Environment ### Hosting Provider: DBH: localhost, SRV: givewp.local TLS Connection: Connection uses TLS 1.2 TLS Connection: Probably Okay Server Info: Apache/2.4.10 (Debian) PHP Version: 7.0.3 PHP Post Max Size: 1,000 MB PHP Time Limit: 900 PHP Max Input Vars: 3000 PHP Max Upload Size: 1,000 MB cURL Version: ❌ 7.38.0, OpenSSL/1.0.1t - We recommend a minimum cURL version of 7.40. SUHOSIN Installed: – MySQL Version: ❌ 5.5.55 - We recommend a minimum MySQL version of 5.6. See: WordPress Requirements Default Timezone is UTC: ✔ fsockopen/cURL: ✔ SoapClient: ✔ DOMDocument: ✔ gzip: ✔ GD Graphics Library: ✔ Multibyte String: ✔ Remote Post: ✔ Remote Get: ✔ ### Give Configuration ### Give Version: 2.2.4 Give Cache: Enabled Database Updates: All DB Updates Completed. Give Cache: Enabled Give Cache: ✔New Donation✔Donation Receipt✔New Offline Donation✔Offline Donation Instructions✔New User Registration✔User Registration Information✔Email access Upgraded From: – Test Mode: Enabled Currency Code: USD Currency Position: Before Decimal Separator: . Thousands Separator: , Success Page: https://givewp.local/donation-confirmation/ Failure Page: https://givewp.local/donation-failed/ Donation History Page: https://givewp.local/donation-history/ Give Forms Slug: /donations/ Enabled Payment Gateways: Test Donation, Offline Donation Default Payment Gateway: Test Donation PayPal IPN Verification: Enabled PayPal IPN Notifications: N/A Donor Email Access: Enabled ### Active Give Add-ons ### ### Other Active Plugins ### ### Inactive Plugins ### BuddyPress: by The BuddyPress Community – 3.0.0 Caldera Forms: by Caldera Labs – 1.5.9.1 Charitable: by WP Charitable – 1.6.1 Debug Bar: by wordpressdotorg – 0.9 Debug Bar Console: by koopersmith – 0.3 Debug Bar Cron: by Zack Tollman, Helen Hou-Sandi – 0.1.2 Debug Bar Extender: by Thorsten Ott, Automattic – 0.5 Developer: by Automattic – 1.2.6 Duplicate Post: by Enrico Battocchi – 3.2.2 Email Cop: by Ashfame – 0.1.1 Give - 2Checkout Gateway: by WordImpress – 1.1.1 Give - AmeriCloud Payments: by AmeriCloud Solutions, Inc. – 1.2.0 Give - Authorize.net Gateway: by WordImpress – 1.4.2 Give - AWeber: by WordImpress – 1.0.3 Give - Braintree Gateway: by WordImpress – 1.2.2 Give - CCAvenue Gateway: by WordImpress – 1.0.1 Give - ConvertKit: by WordImpress – 1.0.1 Give - Currency Switcher: by WordImpress – 1.2.2 Give - Display Donors: by WordImpress, LLC – 1.0 Give - Donation Upsells for WooCommerce: by WordImpress – 1.0.1 Give - Dwolla Gateway: by WordImpress – 1.1.2 Give - Email Reports: by WordImpress – 1.1.2 Give - Fee Recovery: by WordImpress – 1.7.2 Give - Form Countdown: by WordImpress – 1.0 Give - Form Field Manager: by WordImpress – 1.4.0 Give - Gift Aid: by WordImpress – 1.1.6 Give - GoCardless Gateway: by WordImpress – 1.2 Give - Google Analytics Donation Tracking: by WordImpress – 1.2.1 Give - MailChimp: by WordImpress – 1.4.1 Give - Manual Donations: by WordImpress – 1.4.1 Give - Mollie Gateway: by WordImpress – 1.1.2 Give - Paymill Gateway: by WordImpress – 1.1 Give - PayPal Pro Gateway: by WordImpress – 1.1.7 Give - Paytm Gateway: by WordImpress – 1.0 Give - PDF Receipts: by WordImpress – 2.3 Give - Razorpay: by WordImpress – 1.2.0 Give - Razorpay Recurring: by WP Buffs – 1.0 Give - Recurring Donations: by WordImpress – 1.7.2 Give - Stripe Gateway: by WordImpress – 2.0.10 Give - Tributes: by WordImpress – 1.4.2 Give - WePay Gateway: by WordImpress – 1.3.1 Give - Zapier: by WordImpress – 1.1.2 Gravity Forms: by rocketgenius – 2.2.6 Gravity Forms Signature Add-On: by Rocketgenius – 3.4 Gutenberg: by Gutenberg Team – 3.6.2 Loco Translate: by Tim Whitlock – 2.1.4 Log Deprecated Notices: by Andrew Nacin – 0.4 Log Viewer: by Markus Fischbacher – 14.05.04 Monster Widget: by Automattic – 0.3 PHP Compatibility Checker: by WP Engine – 1.4.5 Polylang: by Frédéric Demarle – 2.3.6 qTranslate-X: by qTranslate Team – 3.4.6.8 Query Monitor: by John Blackbourn & contributors – 3.0.1 Rewrite Rules Inspector: by Daniel Bachhuber, Automattic – 1.2.1 User Switching: by John Blackbourn & contributors – 1.3.1 WooCommerce: by Automattic – 3.4.1 WordPress Beta Tester: by Peter Westwood – 1.2.2 WP Hide & Security Enhancer: by Nsp Code – 1.4.9.1 WPML Multilingual CMS: by OnTheGoSystems – 3.9.4 WPS Hide Login: by WPServeur, NicolasKulka, tabrisrp – 1.3.4.2 ### Active MU Plugins ### Local by Flywheel Relative URL (for Live Links): by Flywheel – 1.0 ### Theme ### Name: Twenty Seventeen Version: 1.7 Author URL: https://wordpress.org/ Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme
mehul0810 commented 5 years ago

@ravinderk While testing this issue, I've noticed that only 1 out of 4 scenarios are handled.

Please find the status for each scenario of deleting form meta when the donation form is deleted permanently from Trash section:

  1. using "Empty Trash" button - NOT WORKING
  2. using "Delete Permanently" Quick Actions - WORKING
  3. using "Bulk Actions" - NOT WORKING
  4. Upgrade Routine is required to remove form meta of the donation forms which no longer exists to improve DB performance and exporting DB easier (Related: https://github.com/impress-org/give/issues/2426) - NOT IMPLEMENTED

Hence, re-opening this issue

kevinwhoffman commented 5 years ago

@mehul0810 Please resolve 1-3 for now.

@DevinWalker and I will discuss when it's appropriate to remove the leftover form meta. My thoughts are that most sites won't have much form meta compared to donation meta, so it's probably having very little impact on performance.