impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.
https://givewp.com/
GNU General Public License v3.0
345 stars 191 forks source link

fix: allow selection of more than the first 30 forms in the Export tool #3674

Closed Benunc closed 6 years ago

Benunc commented 6 years ago

Current Behavior

When I go to Tools > Export > Generate CSV, then go to the "Filter by Donation Form" dropdown, it's only showing 30 forms instead of all forms I have.

When I want to download information from a form that's beyond the first 30 (alphabetical) forms, it does not appear.

Instead I get this console error:

Uncaught TypeError: Cannot read property 'no_results_msg' of undefined
    at HTMLSelectElement.<anonymous> (admin-scripts.js:176)
    at HTMLSelectElement.dispatch (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-draggable,jquery-ui-slider,jquery-tou&load[]=ch-punch,iris,wp-color-picker&ver=4.9.8:3)
    at HTMLSelectElement.r.handle (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-draggable,jquery-ui-slider,jquery-tou&load[]=ch-punch,iris,wp-color-picker&ver=4.9.8:3)
    at Object.trigger (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-draggable,jquery-ui-slider,jquery-tou&load[]=ch-punch,iris,wp-color-picker&ver=4.9.8:3)
    at Object.a.event.trigger (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-draggable,jquery-ui-slider,jquery-tou&load[]=ch-punch,iris,wp-color-picker&ver=4.9.8:9)
    at HTMLSelectElement.<anonymous> (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-draggable,jquery-ui-slider,jquery-tou&load[]=ch-punch,iris,wp-color-picker&ver=4.9.8:3)
    at Function.each (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-draggable,jquery-ui-slider,jquery-tou&load[]=ch-punch,iris,wp-color-picker&ver=4.9.8:2)
    at a.fn.init.each (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-draggable,jquery-ui-slider,jquery-tou&load[]=ch-punch,iris,wp-color-picker&ver=4.9.8:2)
    at a.fn.init.trigger (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-draggable,jquery-ui-slider,jquery-tou&load[]=ch-punch,iris,wp-color-picker&ver=4.9.8:3)
    at i.no_results (chosen.jquery.js:1247)
(anonymous) @ admin-scripts.js:176
dispatch @ load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-draggable,jquery-ui-slider,jquery-tou&load[]=ch-punch,iris,wp-color-picker&ver=4.9.8:3
r.handle @ load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-draggable,jquery-ui-slider,jquery-tou&load[]=ch-punch,iris,wp-color-picker&ver=4.9.8:3
trigger @ load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-draggable,jquery-ui-slider,jquery-tou&load[]=ch-punch,iris,wp-color-picker&ver=4.9.8:3
a.event.trigger @ load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-draggable,jquery-ui-slider,jquery-tou&load[]=ch-punch,iris,wp-color-picker&ver=4.9.8:9
(anonymous) @ load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-draggable,jquery-ui-slider,jquery-tou&load[]=ch-punch,iris,wp-color-picker&ver=4.9.8:3
each @ load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-draggable,jquery-ui-slider,jquery-tou&load[]=ch-punch,iris,wp-color-picker&ver=4.9.8:2
each @ load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-draggable,jquery-ui-slider,jquery-tou&load[]=ch-punch,iris,wp-color-picker&ver=4.9.8:2
trigger @ load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-draggable,jquery-ui-slider,jquery-tou&load[]=ch-punch,iris,wp-color-picker&ver=4.9.8:3
i.no_results @ chosen.jquery.js:1247
e.winnow_results @ chosen.jquery.js:387
e.results_search @ chosen.jquery.js:328
e.keyup_checker @ chosen.jquery.js:492
(anonymous) @ chosen.jquery.js:787
dispatch @ load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-draggable,jquery-ui-slider,jquery-tou&load[]=ch-punch,iris,wp-color-picker&ver=4.9.8:3
r.handle @ load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-draggable,jquery-ui-slider,jquery-tou&load[]=ch-punch,iris,wp-color-picker&ver=4.9.8:3

Expected Behavior

I expect to be able to search for all forms.

Steps to Reproduce

  1. On a site with more than 30 donation forms, search for any form that doesn't show up on the list.
  2. View the console.

Related

https://secure.helpscout.net/conversation/661465829/25282?folderId=848135 https://secure.helpscout.net/conversation/662833728/25435/ https://secure.helpscout.net/conversation/672343202/26339/

Acceptance Criteria

Environment

WordPress System Info ### WordPress Environment ### Home URL: http://localgive.local Site URL: http://localgive.local WP Version: 4.9.8 WP Multisite: – WP Memory Limit: 256 MB WP Debug Mode: ✔ WP Cron: ✔ Language: en_US Permalink Structure: /%year%/%monthnum%/%day%/%postname%/ Show on Front: posts Table Prefix Length: wp_ Table Prefix Length: 3 Table Prefix Status: Acceptable Admin AJAX: Accessible Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, refunded, failed, revoked, cancelled, abandoned, processing, preapproval ### Server Environment ### Hosting Provider: DBH: localhost, SRV: localgive.local TLS Connection: Connection uses TLS 1.2 TLS Connection: Probably Okay Server Info: Apache/2.4.10 (Debian) PHP Version: 7.0.3 PHP Post Max Size: 1,000 MB PHP Time Limit: 900 PHP Max Input Vars: 3000 PHP Max Upload Size: 1,000 MB cURL Version: ❌ 7.38.0, OpenSSL/1.0.1t - We recommend a minimum cURL version of 7.40. SUHOSIN Installed: – MySQL Version: ❌ 5.5.55 - We recommend a minimum MySQL version of 5.6. See: WordPress Requirements Default Timezone is UTC: ✔ fsockopen/cURL: ✔ SoapClient: ✔ DOMDocument: ✔ gzip: ✔ GD Graphics Library: ✔ Multibyte String: ✔ Remote Post: ✔ Remote Get: ✔ ### Give Configuration ### Give Version: 2.2.4 Give Cache: Enabled Database Updates: All DB Updates Completed. Give Cache: Enabled Give Cache: ✔New Donation✔TRANSLATEIT❌New Offline Donation❌Offline Donation Instructions✔New User Registration✔User Registration Information✔Email access Upgraded From: 2.2.2 Test Mode: Enabled Currency Code: USD Currency Position: Before Decimal Separator: . Thousands Separator: , Success Page: http://localgive.local/donation-confirmation/ Failure Page: http://localgive.local/donation-failed/ Donation History Page: http://localgive.local/donation-history/ Give Forms Slug: /donations/ Enabled Payment Gateways: Stripe - Credit Card, Test Donation, Authorize.net Default Payment Gateway: Stripe - Credit Card PayPal IPN Verification: Disabled PayPal IPN Notifications: N/A Donor Email Access: Enabled ### Active Give Add-ons ### Give - Authorize.net Gateway: ❌ Unlicensed – by WordImpress – 1.4.2 Give - Currency Switcher: ❌ Unlicensed – by WordImpress – 1.2.2 Give - Stripe Gateway: ❌ Unlicensed – by WordImpress – 2.0.10 Give - Tributes: ❌ Unlicensed – by WordImpress – 1.3.5 ### Other Active Plugins ### Ben's Helper Functions: by BenUNC – Give - Hook Helper: by Ravinder Kumar – 1.0 Page Builder by SiteOrigin: by SiteOrigin – 2.8.2 Salient Visual Composer: by Michael M - WPBakery.com | Modified by ThemeNectar – 5.2.4 SiteOrigin Widgets Bundle: by SiteOrigin – 1.12.1 ### Inactive Plugins ### Advanced Custom Fields: by Elliot Condon – 4.4.12 Akismet Anti-Spam: by Automattic – 4.0.8 Better Search Replace: by Delicious Brains – 1.3.2 Debug Bar: by wordpressdotorg – 0.9 Debug Bar Post Meta: by whyisjake – 0.5.5 Divi Builder: by Elegant Themes – 2.3.1 Duplicate Post: by Enrico Battocchi – 3.2.2 Duplicator: by Snap Creek – 1.2.42 Elegant Themes Support: by Elegant Themes – 1.3 Elementor: by Elementor.com – 2.2.1 Fusion Builder: by ThemeFusion – 1.0.6 Fusion Core: by ThemeFusion – 3.0.6 Give - 2Checkout Gateway: by WordImpress – 1.0.2 Give - Braintree Gateway: by WordImpress – 1.2.2 Give - Constant Contact: by WordImpress – 1.2.1 Give - ConvertKit: by WordImpress – 1.0.2 Give - CSV Toolbox: by WordImpress – 1.0 Give - Dwolla Gateway: by WordImpress – 1.1.2 Give - Email Reports: by WordImpress – 1.1.2 Give - Fee Recovery: by WordImpress – 1.7.0 Give - Form Countdown: by WordImpress – 1.0.1 Give - Form Field Manager: by WordImpress – 1.3 Give - GoCardless Gateway: by WordImpress – 1.1.2 Give - Google Analytics Donation Tracking: by GiveWP – 1.2.1 Give - iATS Payment Solutions: by WordImpress – 1.0.2 Give - MailChimp: by WordImpress – 1.4.1 Give - Manual Donations: by WordImpress – 1.4.1 Give - Old Meta Switcher: by WordImpress – 1.0 Give - Paymill Gateway: by WordImpress – 1.1 Give - PayPal Pro Gateway: by WordImpress – 1.1.6 Give - Paytm Gateway: by WordImpress – 1.0 Give - PayUmoney: by WordImpress – 1.0.1 Give - PDF Receipts: by WordImpress – 2.3 Give - Per Form Gateways: by WordImpress – 1.0.1 Give - Razorpay: by WordImpress – 1.1.3 Give - Recurring Donations: by WordImpress – 1.7.2 Give - Recurring Helper: by WordImpress – 1.0 Give - Update Goal Progress: by Matt Cromwell – 1.0 Give - WePay Gateway: by WordImpress – 1.3.1 Give - WP All Import Addon: by Ben Meredith – 1.0 Give - Zapier: by WordImpress – 1.2.1 Give Stripe Cleanup.: by BenUNC – Google Analytics Dashboard for WP (GADWP): by ExactMetrics – 5.3.5 Google Analytics for WordPress by MonsterInsights: by MonsterInsights – 7.1.0 Gravity Forms: by rocketgenius – 2.2.6 Hello Dolly: by Matt Mullenweg – 1.6 MailChimp for WordPress: by ibericode – 4.2.4 MailChimp User Sync: by ibericode – 1.7.5 MOJO Marketplace: by Mike Hansen – 1.3.4 Query Monitor: by John Blackbourn & contributors – 3.1.0 RegistrationMagic Premium: by Registrationmagic – 3.8.3.8 Shortcode in Menus: by Gagan Deep Singh – 3.4 Transients Manager: by Pippin Williamson – 1.7.5 User Switching: by John Blackbourn & contributors – 1.3.1 WPBakery Page Builder: by Michael M - WPBakery.com – 5.3 WP Crontrol: by John Blackbourn & contributors – 1.6.2 WP Rocket: by WP Media – 3.0.5.1 WP Simple Pay (Lite Version): by WP Simple Pay – 2.0.11 Yoast SEO: by Team Yoast – 8.1.2 ### Active MU Plugins ### Bypass Login: by Stephen Carnam – 1.1.0 hide-give-license-warning.php: by – Local by Flywheel Relative URL (for Live Links): by Flywheel – 1.0 ### Theme ### Name: Twenty Seventeen Version: 1.7 Author URL: https://wordpress.org/ Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme
kevinwhoffman commented 6 years ago

@raftaar1191 Explore using the AJAX Chosen field for viewing more than 30 forms.

raftaar1191 commented 6 years ago

Here the Ajax search is already implemented but when ajax run there is some JS error because of which the Ajax form search is not working

image

DevinWalker commented 6 years ago

@raftaar1191 please investigate the cause of that and resolve.