samsmith89 commented 5 years ago

Bug Report

User Story

As a site admin, I want to update to Give 2.4.0 without getting a fatal error when CSV Toolbox is enabled so that I can sign into the backend of my site.

Current Behavior

I'm presented with a 500 error if WP_DEBUG is not enabled, and a fatal error with WP_DEBUG enabled.

Expected Behavior

I expect to log in with both addons activated or have CSV Toolbox deactivate as it isn't useful anymore.

Bug Type

[x] This bug describes functionality that once worked as expected in version X.X.X.
[ ] This bug describes functionality that never worked as expected.
[ ] I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

Install Give CSV Toolbox and Give 2.4.0. Download CSV Toolbox here: https://drive.google.com/file/d/1ADbhk9PBRxnGnl_Ks3elE4nDeE4kwF3b/view?usp=sharing
Visit the wp-login.php page
See the error that dispalys

Visuals

screen shot 2019-01-17 at 11 30 50 am

Possible Solution

Add logic that auto-deactivates CSV Toolbox when Give is updated to 2.4.0

Acceptance Criteria

[ ] I can update Give to 2.4.0 with CSV Toolbox enabled without getting an error on the login page

Environment

Operating System

Platform: Mac OS X

Browser

Name: Chrome

WordPress System Info

### WordPress Environment ### Home URL: http://templeofthevedicplanetarium.local Site URL: http://templeofthevedicplanetarium.local WP Version: 4.9.9 WP Multisite: – WP Memory Limit: 256 MB WP Debug Mode: – WP Cron: ✔ Language: en_US Permalink Structure: /%category%/%postname%/ Show on Front: page Page on Front: Temple of the Vedic Planetarium – Home (#605) Page for Posts: NEWS (#606) Table Prefix Length: t0vp_ Table Prefix Length: 5 Table Prefix Status: Acceptable Admin AJAX: Accessible Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, refunded, failed, revoked, cancelled, abandoned, processing, preapproval, give_subscription ### Server Environment ### Hosting Provider: DBH: localhost, SRV: templeofthevedicplanetarium.local TLS Connection: Connection uses TLS 1.2 TLS Connection: Probably Okay Server Info: Apache/2.4.10 (Debian) PHP Version: 7.0.3 PHP Post Max Size: 1,000 MB PHP Time Limit: 900 PHP Max Input Vars: 3000 PHP Max Upload Size: 1,000 MB cURL Version: ❌ 7.38.0, OpenSSL/1.0.1t - We recommend a minimum cURL version of 7.40. SUHOSIN Installed: – MySQL Version: 5.6.34 Default Timezone is UTC: ✔ fsockopen/cURL: ✔ SoapClient: ✔ DOMDocument: ✔ gzip: ✔ GD Graphics Library: ✔ Multibyte String: ✔ Remote Post: ✔ Remote Get: ✔ ### Give Configuration ### Give Version: 2.4.0 Give Cache: Enabled Database Updates: All DB Updates Completed. Give Cache: Enabled Give Cache: ✔New Donation✔Donation Receipt❌New Offline Donation❌Offline Donation Instructions✔New User Registration✔User Registration Information✔Donor Note✔Email access✔Daily Email Report✔Weekly Email Report✔Monthly Email Report✔Renewal Receipt Email❌Renewal Receipt Email✔Subscription Cancelled Email❌Subscription Cancelled Email✔Subscription Completed Email❌Subscription Reminder Email✔Subscriptions Email Access Upgraded From: 2.4.0 Test Mode: Enabled Currency Code: USD Currency Position: Before Decimal Separator: . Thousands Separator: , Success Page: http://templeofthevedicplanetarium.local/donation-confirmation/ Failure Page: http://templeofthevedicplanetarium.local/donation-failed/ Donation History Page: http://templeofthevedicplanetarium.local/donation-history/ Give Forms Slug: /donations/ Enabled Payment Gateways: Stripe - Credit Card, PayPal Website Payments Pro (REST API), PayPal Standard, Razorpay Default Payment Gateway: Stripe - Credit Card PayPal IPN Verification: Enabled PayPal IPN Notifications: IPN received for #54069 ( 7YG692930P918741T ) on 12/19/2018 at 07:22. Status VERIFIED Donor Email Access: Enabled ### Active Give Add-ons ### Give - Currency Switcher: ❌ Unlicensed – by GiveWP – 1.3.1 Give - Email Reports: ✔ Licensed – by WordImpress – 1.1.2 Give - Fee Recovery: ❌ Unlicensed – by GiveWP – 1.7.3 Give - Form Field Manager: ❌ Unlicensed – by GiveWP – 1.4.1 Give - Manual Donations: ❌ Unlicensed – by GiveWP – 1.4.2 Give - PayPal Pro Gateway: ❌ Unlicensed – by GiveWP – 1.2.1 Give - PDF Receipts: ❌ Unlicensed – by GiveWP – 2.3.2 Give - Per Form Gateways: ✔ Licensed – by WordImpress – 1.0.1 Give - Razorpay: ❌ Unlicensed – by GiveWP – 1.2.1 Give - Recurring Donations: ❌ Unlicensed – by GiveWP – 1.8.3 Give - Stripe Gateway: ❌ Unlicensed – by GiveWP – 2.1.2 Give - Tributes: ❌ Unlicensed – by GiveWP – 1.5.2 ### Other Active Plugins ### Give - Calculator: by WP Buffs – 1.0 Give - Razorpay Recurring: by WP Buffs – 1.0 ### Inactive Plugins ### amCharts Embed: by Rami Yushuvaev – 1.3 Bookly: by Bookly – 16.5 Bookly Cart (Add-on): by Bookly – 1.3 Bookly Custom Fields (Add-on): by Bookly – 1.5 Bookly Packages (Add-on): by Ladela Interactive – 1.7 Bookly PayPal Payments Standard (Add-on): by Bookly – 1.8 Bookly Pro (Add-on): by Bookly – 1.1 Bookly Razor Pay (Add-on): by [WPKraken] Grzesiek & Przemo – 1.3 Bookly Razor Pay (Add-on): by [WPKraken] Grzesiek – 1.2 Bookly Special Days (Add-on): by Bookly – 2.4 Bookly Special Hours (Add-on): by Bookly – 2.1 Bookly Stripe (Add-on): by Bookly – 1.5 Bootstrap for Contact Form 7: by Felix Arntz – 1.4.8 Chatra live chat software: by Chatra – 1.0.5 Contact Form 7: by Takayuki Miyoshi – 5.1.1 Contact Form 7 Conditional Fields: by Jules Colle – 1.4.1 Contact Form CFDB7: by Arshid – 1.2.4.5 Duplicate Post: by Enrico Battocchi – 3.2.2 Duplicator: by Snap Creek – 1.3.2 DZS Video Gallery: by Digital Zoom Studio – 11.00 Embed Any Document: by Awsm Innovations – 2.4.1 Envato Market: by Envato – 2.0.1 Give - CSV Toolbox: by WordImpress – 1.0 Give - GoCardless Gateway: by WordImpress – 1.2.1 Give - Paytm Gateway: by WordImpress – 1.0.1 Google Analytics for WordPress by MonsterInsights: by MonsterInsights – 7.3.3 NextGEN Gallery: by Imagely – 3.1.5 NextGEN Plus: by Imagely – 1.6.8 Nginx Helper: by rtCamp – 2.0.1 NinjaFirewall (WP Edition): by The Ninja Technologies Network – 3.8.1 NinjaScanner: by The Ninja Technologies Network – 1.3.3 Paytm Payment Donation: by Paytm – 1.0 Really Simple CAPTCHA: by Takayuki Miyoshi – 2.0.1 Search & Replace: by Inpsyde GmbH – 3.1.2 SendGrid: by SendGrid – 1.11.8 SparkPost: by SparkPost – 3.2.0 SSL Insecure Content Fixer: by WebAware – 2.7.2 Term Management Tools: by scribu – 1.1.4 UpdraftPlus - Backup/Restore: by UpdraftPlus.Com, DavidAnderson – 1.16.0 wpDataTables: by TMS-Plugins – 2.4 WPML Media: by OnTheGoSystems – 2.4.1 WPML Multilingual CMS: by OnTheGoSystems – 4.1.3 WPML String Translation: by OnTheGoSystems – 2.9.1 WPML Translation Analytics: by OnTheGoSystems – 1.0.7 WPML Translation Management: by OnTheGoSystems – 2.7.2 WP User Avatar: by flippercode – 2.1.6 Yoast SEO: by Team Yoast – 9.4 ZNPB Blog-Posts Layouts Element: by Hogash Studio – 1.1.1 ZNPB Counter Element: by Balasa Sorin Stefan – 1.0.2 ### Theme ### Name: Kallyas Child Theme Version: 1.0 Author URL: http://themeforest.net/user/hogash Child Theme: Yes Parent Theme Name: Kallyas Parent Theme Version: 4.16.8 Parent Theme Author URL: http://themeforest.net/user/hogash

kevinwhoffman commented 5 years ago

@DevinWalker and @mathetos will discuss to see how widespread the use of CSV toolbox is and whether a 2.4.1 release would be warranted to look for the plugin and uninstall it upon update.

DevinWalker commented 5 years ago

@mathetos and I spoke about the best way forward here.

Summary:

Estimated users of CSV toolbox is around 100 - 120.
We don't really want to modify core to handle CSV toolbox incorrect logic (toolbox should've ever only been initialized on wp-admin which it wasn't being).
Most users won't know how to FTP in and remove the plugin
Around 3 customers since 2.4.0 was released have submitted tickets complaining of the issue

Plan of Action

@mathetos is going to try and see if he can export the list of CSV Toolbox users in Help Scout and email them proactively explaining to remove the plugin before upgrading to the new version.