search

impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.
https://givewp.com/
GNU General Public License v3.0
340 stars 191 forks source link

fix: prevent failed donation history export on export without specified date range. #4079

Closed marutim closed 5 years ago

marutim commented 5 years ago

Bug Report

User Story

As an admin I would like to export donation from Tools >> Export >> Export donation history without having to set a date parameter.

Now when you try it with no selection or with selecting a donation form or with any other filter(except for restricting the date) it does export the donation.

Current Behavior

Leaving the date blank, Export donation is not working.

Expected Behavior

Admin should be able to export donation and use its different filter.

Bug Type

Steps to Reproduce

  1. Go to Tools >> Export >> Export Donation and try exporting CSV without changing any parameters.
  2. No CSV will be exported and you will alerted with "No data found for export parameters"
  3. Select a specific form from the dropdown, and it still will not work.
  4. Select a start and end date from the date pickers, and things will work.

Visuals

Give Tools ‹ WP Give — WordPress

Related

HS link: https://secure.helpscout.net/conversation/821572784/37177?folderId=1457790

Acceptance Criteria

Environment

### WordPress Environment ### Home URL: http://give-wp.local Site URL: http://give-wp.local WP Version: 5.1.1 WP Multisite: – WP Memory Limit: 256 MB WP Debug Mode: ✔ WP Cron: ✔ Language: en_US Permalink Structure: /%postname%/ Show on Front: posts Table Prefix Length: wp_ Table Prefix Length: 3 Table Prefix Status: Acceptable Admin AJAX: Accessible Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, refunded, failed, revoked, cancelled, abandoned, processing, preapproval, give_subscription ### Server Environment ### Hosting Provider: DBH: localhost, SRV: give-wp.local TLS Connection: Connection uses TLS 1.2 TLS Connection: Probably Okay Server Info: nginx/1.14.0 PHP Version: 7.2.9 PHP Post Max Size: 1,000 MB PHP Time Limit: 1200 PHP Max Input Vars: 4000 PHP Max Upload Size: 300 MB cURL Version: 7.52.1, OpenSSL/1.0.2l SUHOSIN Installed: – MySQL Version: 5.7.23 Default Timezone is UTC: ✔ fsockopen/cURL: ✔ SoapClient: ✔ DOMDocument: ✔ gzip: ✔ GD Graphics Library: ✔ Multibyte String: ✔ Remote Post: ✔ Remote Get: ✔ ### Give Configuration ### Give Version: 2.4.4 Give Cache: Enabled Database Updates: All DB Updates Completed. Database Tables: ✔ wp_give_donors - 1.0✔ wp_give_donormeta - 1.0✔ wp_give_comments - 1.0✔ wp_give_commentmeta - 1.0✔ wp_give_sessions - 1.0✔ wp_give_logs - 1.0✔ wp_give_logmeta - 1.0✔ wp_give_formmeta - 1.0✔ wp_give_sequential_ordering - 1.0✔ wp_give_donationmeta - 1.0 Give Cache: Enabled Give Cache: ✔New Donation✔Donation Receipt❌New Offline Donation❌Offline Donation Instructions✔New User Registration✔User Registration Information✔Donor Note✔Email access✔Daily Email Report✔Weekly Email Report❌Monthly Email Report✔Renewal Receipt Email❌Renewal Receipt Email✔Subscription Cancelled Email❌Subscription Cancelled Email✔Subscription Completed Email✔Subscription Reminder Email✔Subscriptions Email Access Upgraded From: 2.4.3 Test Mode: Enabled Currency Code: GBP Currency Position: After Decimal Separator: . Thousands Separator: , Success Page: http://give-wp.local/donation-confirmation/ Failure Page: http://give-wp.local/donation-failed/ Donation History Page: http://give-wp.local/donation-history/ Give Forms Slug: /donations/ Enabled Payment Gateways: Test Donation, PayPal Standard, Stripe - Credit Card, Paytm Default Payment Gateway: Stripe - Credit Card PayPal IPN Verification: Enabled PayPal IPN Notifications: N/A Donor Email Access: Enabled ### Active Give Add-ons ### Give - Authorize.net Gateway: ✔ Licensed – by GiveWP – 1.4.6 Give - Currency Switcher: ✔ Licensed – by GiveWP – 1.3.1 Give - Email Reports: ✔ Licensed – by WordImpress – 1.1.2 Give - Fee Recovery: ✔ Licensed – by GiveWP – 1.7.4 Give - Form Field Manager: ✔ Licensed – by GiveWP – 1.4.1 Give - GoCardless Gateway: ✔ Licensed – by GiveWP – 1.3.2 Give - Manual Donations: ✔ Licensed – by GiveWP – 1.4.3 Give - Mollie Gateway: ❌ Unlicensed – by GiveWP – 1.2.1 Give - PayPal Pro Gateway: ✔ Licensed – by GiveWP – 1.2.1 Give - Paytm Gateway: ✔ Licensed – by GiveWP – 1.1.0 Give - PayUmoney: ❌ Unlicensed – by GiveWP – 1.0.4 Give - PDF Receipts: ✔ Licensed – by GiveWP – 2.3.3 Give - Recurring Donations: ❌ Unlicensed – by GiveWP – 1.8.11 Give - Stripe Gateway: ✔ Licensed – by GiveWP – 2.1.6 Give - Tributes: ✔ Licensed – by GiveWP – 1.5.2 ### Other Active Plugins ### Debug Bar: by wordpressdotorg – 1.0 Disable Real MIME Check: by Sergey Biryukov – 1.0 User Switching: by John Blackbourn & contributors – 1.5.0 ### Inactive Plugins ### Automatic Responsive Tables: by Andrew Rockwell – 1.2 Debug Bar Post Meta: by whyisjake – 0.5.5 Email Cop: by Ashfame – 0.1.1 Give - AmeriCloud Payments: by AmeriCloud Solutions, Inc. – 1.2.0 Give - Braintree Gateway: by WordImpress – 1.1.1 Give - CCAvenue Gateway: by GiveWP – 1.0.4 Give - Constant Contact: by WordImpress – 1.2.1 Give - ConvertKit: by WordImpress – 1.0.1 Give - CSV Toolbox: by WordImpress – 1.0 Give - Form Countdown: by WordImpress – 1.0.1 Give - Gift Aid: by WordImpress – 1.1.6 Give - Google Analytics Donation Tracking: by WordImpress – 1.1.1 Give - Hook Helper: by Ravinder Kumar – 1.0 Give - MailChimp: by GiveWP – 1.4.2 Give - Per Form Gateways: by GiveWP – 1.0.2 Give - Per Form User Role Assigner: by Matt Cromwell – 1.0 Give - Razorpay: by WordImpress – 1.2.0 Give - Recurring Helper: by WordImpress – 1.0 Give - Zapier: by WordImpress – 1.2.1 Intuitive Custom Post Order: by hijiri – 3.1.2 My Custom Functions: by Space X-Chimp – 4.38 Page Builder by SiteOrigin: by SiteOrigin – 2.10.5 Shortcode in Menus: by Gagan Deep Singh – 3.5 SiteOrigin Widgets Bundle: by SiteOrigin – 1.15.4 The Events Calendar: by Modern Tribe, Inc. – 4.8.2 The Events Calendar: Eventbrite Tickets: by Modern Tribe, Inc. – 4.5.5 WP Filters Extras: by BeAPI – 1.0.2 ### Active MU Plugins ### Local by Flywheel Relative URL (for Live Links): by Flywheel – 1.0 ### Theme ### Name: Twenty Seventeen Version: 2.1 Author URL: https://wordpress.org/ Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme
DevinWalker commented 5 years ago

Resolved in merged PR above