impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.
https://givewp.com/
GNU General Public License v3.0
340 stars 191 forks source link

fix: multiple same payment methods stored even though logic in place for SEPA #4570

Closed mehul0810 closed 2 years ago

mehul0810 commented 4 years ago

Bug Report

User Story

As a user, I want to store a SEPA payment method once if the same is used for the second time so that it doesn't create an unnecessary payment method for the Stripe customer.

Related to https://github.com/impress-org/givewp/issues/4313

Current Behavior

Currently, when I use same IBAN account number for one user for multiple donations then multiple payment methods are created for the same user having same IBAN account number

Expected Behavior

I expect to discuss this scenario with Stripe developers as to when fetching the payment method list via API I am getting empty results even though there is an IBAN account number payment method due to which this issue is present.

Bug Type

Acceptance Criteria

jonwaldstein commented 2 years ago

I see we're using the setup_future_usage payment intent argument for Stripe (SEPA) which in theory should work.

There is also these (newer) docs around the subject.

https://stripe.com/docs/payments/sepa-debit/set-up-payment

@DevinWalker do you have any recollection of this being an issue with customers? or is this just an optimization we've identified?

@kjohnson did you happen to run into this when you were migrating SEPA to the gateway api?

JoshuaHungDinh commented 2 years ago

No recent feedback. Related to https://github.com/impress-org/givewp/issues/4313