impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.
https://givewp.com/
GNU General Public License v3.0
345 stars 191 forks source link

feature: load fontawesome assets on build step (do not track w version control) #4601

Closed lindseymacmillan closed 2 years ago

lindseymacmillan commented 4 years ago

Feature Request

User Story

As a developer, I want FontAwesome assets loaded during a build step so that the GiveWP repo is not tracking all FontAwesome assets in version control.

Details

Additionally, only specific needed icons should be packaged within the plugin's assets directory.

While FontAwesome assets are primarily used in the GiveWP admin interface, they will increasingly find use in new Form Templates. We should discuss how these Form Templates (eg Sequoia) should best pull in FontAwesome assets where needed.

Possible Solution

See Using Package Managers doc on FontAwesome website: https://fontawesome.com/how-to-use/on-the-web/setup/using-package-managers

Also see font-awesome package on npm: https://www.npmjs.com/package/font-awesome

Acceptance Criteria

JasonTheAdams commented 4 years ago

This looks great, @henryholtgeerts. Thanks for putting this together!

jonwaldstein commented 2 years ago

We're mainly using the @fortawesome packages these days so this may have already been resolved.