matheuswd commented 4 years ago

Bug Report

User Story

As a site owner, I want to create a donor wall with multiple form IDs.

Details

Current Behavior

When the donor tries to add more than one form ID separated by a comma for the donor wall block, it loads only the donors from the first form.

Expected Behavior

The donor wall must load donors from all the form IDs that the site owner defines on the Donor Wall Settings block.

Bug Type

[ ] This bug describes functionality that once worked as expected in version X.X.X.
[ ] This bug describes functionality that never worked as expected.
[x] I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

Make sure you are using Gutenberg Blocks
Create two different forms and make 1 or 2 donations for each one
Create a page/post and add the Donor Wall Block
Add the two previous form IDs to the Form ID field

Visuals

Quick video to replicate the issue http://somup.com/cY1QIaQlQY

Screen Shot 2020-06-09 at 14 36 17

Acceptance Criteria

[ ] donor wall should load all the donors from the form IDs defined by the site owner

Environment

WordPress Environment

Home URL: https://givewptest.matheuswd.com.br Site URL: https://givewptest.matheuswd.com.br WP Version: 5.4.1 WP Multisite: – WP Memory Limit: 256 MB WP Debug Mode: ✔ WP Cron: ✔ Language: enUS Permalink Structure: /%postname%/ Show on Front: posts Table Prefix Length: wp Table Prefix Length: 3 Table Prefix Status: Acceptable Admin AJAX: Accessible Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, refunded, failed, revoked, cancelled, abandoned, processing, preapproval, give_subscription

Server Environment

Hosting Provider: DBH: localhost, SRV: givewptest.matheuswd.com.br TLS Connection: Connection uses TLS 1.2 TLS Connection: Probably Okay Server Info: nginx/1.10.3 PHP Version: 7.0.33-26+ubuntu16.04.1+deb.sury.org+1 PHP Post Max Size: 100 MB PHP Time Limit: 300 PHP Max Input Vars: 1000 PHP Max Upload Size: 100 MB cURL Version: 7.47.0, OpenSSL/1.0.2g SUHOSIN Installed: – Default Timezone is UTC: ✔ fsockopen/cURL: ✔ SoapClient: ✔ DOMDocument: ✔ gzip: ✔ GD Graphics Library: ✔ Multibyte String: ✔ Remote Post: ✔ Remote Get: ✔

GiveWP Configuration

GiveWP Version: 2.6.3 GiveWP Cache: Enabled Database Updates: All DB Updates Completed. Database Tables: ✔ wp_give_donors - 1.0✔ wp_give_donormeta - 1.0✔ wp_give_comments - 1.0✔ wp_give_commentmeta - 1.0✔ wp_give_sessions - 1.0✔ wp_give_logs - 1.0✔ wp_give_logmeta - 1.0✔ wp_give_formmeta - 1.0✔ wp_give_sequential_ordering - 1.0✔ wp_give_donationmeta - 1.0 GiveWP Cache: Enabled GiveWP Cache: ✔New Donation✔Donation Receipt❌New Offline Donation❌Offline Donation Instructions✔New User Registration✔User Registration Information✔Donation Note✔Email access✔Daily Email Report✔Weekly Email Report✔Monthly Email Report❌Renewal Receipt Email❌Renewal Receipt Email❌Subscription Cancelled Email❌Subscription Cancelled Email❌Subscription Completed Email❌Subscription Reminder Email✔Subscriptions Email Access✔Subscription Payment Failed Email Upgraded From: 2.6.2 Test Mode: Enabled Currency Code: BRL Currency Position: Before Decimal Separator: , Thousands Separator: . Success Page: https://givewptest.matheuswd.com.br/donation-confirmation/ Failure Page: https://givewptest.matheuswd.com.br/donation-failed/ Donation History Page: https://givewptest.matheuswd.com.br/donation-history/ GiveWP Forms Slug: /donations/ Enabled Payment Gateways: Test Donation, PayPal Standard Default Payment Gateway: PayPal Standard PayPal IPN Verification: Enabled PayPal IPN Notifications: IPN received for #488 ( 94M039520T040271P ) on 06/08/2020 at 15:20. Status VERIFIED Donor Email Access: Enabled Stripe Webhook Notifications: 2020-06-03 9:24 pm

Active GiveWP Add-ons

Give - Authorize.net Gateway: ✔ Licensed – by GiveWP – 1.4.6 Give - Email Reports: ✔ Licensed – by GiveWP – 1.1.4 Give - Fee Recovery: ✔ Licensed – by GiveWP – 1.7.8 Give - Form Field Manager: ✔ Licensed – by GiveWP – 1.4.6 Give - MailChimp: ✔ Licensed – by GiveWP – 1.4.6 Give - Per Form Gateways: ✔ Licensed – by GiveWP – 1.0.2 Give - Razorpay: ✔ Licensed – by GiveWP – 1.4.3 Give - Recurring Donations: ✔ Licensed – by GiveWP – 1.10.2 Give - Stripe Gateway: ✔ Licensed – by GiveWP – 2.2.5 Give - Tributes: ✔ Licensed – by GiveWP – 1.5.6

Other Active Plugins

Akismet Anti-Spam: by Automattic – 4.1.6 Duplicator: by Snap Creek – 1.3.34 Nginx Helper: by rtCamp – 2.2.2 User Switching: by John Blackbourn & contributors – 1.5.4 WP Rollback: by Impress.org – 1.7.0

Inactive Plugins

Give - Gift Aid: by GiveWP – 1.2.3 Give - PayPal Pro Gateway: by GiveWP – 1.2.2

Theme

Name: Twenty Seventeen Version: 2.3 Author URL: https://wordpress.org/ Child Theme: No – If you're modifying GiveWP on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

DevinWalker commented 4 years ago

Currently we don't support multiple forms within the donor wall shortcode. Where did you see that we did? I don't see any mention of that in our documentation: https://givewp.com/documentation/core/shortcodes/give_donor_wall/

We probably should though...

matheuswd commented 4 years ago

Hey @DevinWalker,

I found it here https://givewp.com/documentation/core/blocks/donor-wall-block/

Form ID Settings Type: Text field Default: “All Forms”

Specify which donors to display based on the form ID they donated through. Form IDs can be found on the “All Forms” page by hovering over the “Copy Shortcode” link. Multiple forms can be included by separating them with a comma.

kamurj commented 4 years ago

Did you have a chance to check it?

jonwaldstein commented 2 years ago

@alaca can you take a quick look at this when you get a chance? We should probably refactor this to use the query builder at some point.

alaca commented 2 years ago

@jonwaldstein this feature is added here https://github.com/impress-org/givewp/pull/6344 so you can close this issue. I didn't use QB because most of the query logic was already there.