impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.
https://givewp.com/
GNU General Public License v3.0
340 stars 191 forks source link

Google Pay button should appear on Chrome (desktop) #5197

Closed lindseymacmillan closed 4 years ago

lindseymacmillan commented 4 years ago

4344

User Story

As a donor who has cards saved to Google Pay, I want Stripe Google Pay to be able to access my payment methods if they are saved to Google Pay for use on any of my devices.

Details

Currently when the card is saved to Google Pay (and not just to the specific device's Chrome account), Google Pay doesn't show an option to pay.

Expected Behavior

I expect to have the option to pay with any payment method saved to to Google Pay.

Steps to Reproduce

This is easiest to explain with a video:

https://screencast-o-matic.com/watch/cYio2HEVTI

Additional Context

Canny post: https://givewp.canny.io/admin/feedback/bug-reports/p/google-pay-button-should-appear-on-chrome-desktop I also tried the same procedure on a Chomebook with the latest Chrome OS, to confirm that it is not just an issue with macOS.

System Information

Details ### WordPress Environment ### Home URL: https://livegive.wpsteward.com Site URL: https://livegive.wpsteward.com WP Version: 5.4.2 WP Multisite: – WP Memory Limit: 256 MB WP Debug Mode: ✔ WP Cron: ✔ Language: en_US Permalink Structure: /%postname%/ Show on Front: posts Table Prefix Length: wp_8138bfdc07_ Table Prefix Length: 14 Table Prefix Status: Acceptable Admin AJAX: Accessible Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, refunded, failed, revoked, cancelled, abandoned, processing, preapproval, give_subscription ### Server Environment ### Hosting Provider: DBH: localhost, SRV: livegive.wpsteward.com TLS Connection: Connection uses TLS 1.2 TLS Connection: Probably Okay Server Info: Apache/2.4.43 (Unix) OpenSSL/1.0.1f PHP Version: 7.3.20 PHP Post Max Size: 1 GB PHP Time Limit: 30 PHP Max Input Vars: 5000 PHP Max Upload Size: 512 MB cURL Version: ❌ 7.35.0, OpenSSL/1.0.1f - We recommend a minimum cURL version of 7.40. SUHOSIN Installed: – MySQL Version: ❌ 5.5.62 - We recommend a minimum MySQL version of 5.6. See: WordPress Requirements Default Timezone is UTC: ✔ fsockopen/cURL: ✔ SoapClient: ✔ DOMDocument: ✔ gzip: ✔ GD Graphics Library: ✔ Multibyte String: ✔ Remote Post: ✔ Remote Get: ✔ ### GiveWP Configuration ### GiveWP Version: 2.7.2 GiveWP Cache: Enabled Database Updates: All DB Updates Completed. Database Tables: ✔ wp_8138bfdc07_give_donors - 1.0✔ wp_8138bfdc07_give_donormeta - 1.0✔ wp_8138bfdc07_give_comments - 1.0✔ wp_8138bfdc07_give_commentmeta - 1.0✔ wp_8138bfdc07_give_sessions - 1.0✔ wp_8138bfdc07_give_logs - 1.0✔ wp_8138bfdc07_give_logmeta - 1.0✔ wp_8138bfdc07_give_formmeta - 1.0✔ wp_8138bfdc07_give_sequential_ordering - 1.0✔ wp_8138bfdc07_give_donationmeta - 1.0 GiveWP Cache: Enabled GiveWP Cache: ✔New Donation✔Donation Receipt❌New Offline Donation❌Offline Donation Instructions✔New User Registration✔User Registration Information✔Donation Note❌Email access❌Renewal Receipt Email✔Renewal Receipt Email❌Subscription Cancelled Email❌Subscription Cancelled Email❌Subscription Completed Email❌Subscription Reminder Email❌Subscriptions Email Access✔Subscription Payment Failed Email Upgraded From: 2.7.1 Test Mode: Enabled Currency Code: USD Currency Position: Before Decimal Separator: . Thousands Separator: , Success Page: https://livegive.wpsteward.com/donation-confirmation/ Failure Page: https://livegive.wpsteward.com/donation-failed/ Donation History Page: https://livegive.wpsteward.com/donation-history/ GiveWP Forms Slug: /donations/ Enabled Payment Gateways: Stripe - Google Pay, Stripe - Apple Pay, PayPal Payments Pro, Stripe + Plaid, Stripe - Credit Card, Authorize.net, Test Donation Default Payment Gateway: Test Donation PayPal IPN Verification: Enabled PayPal IPN Notifications: IPN received for #2586 ( 8TJ24707AH7600052 ) on 05/22/2020 at 16:00. Status VERIFIED Donor Email Access: Disabled Stripe Webhook Notifications: July 16, 2020 8:20 pm Square Token Renewal Date: 2020-04-15 13:30:46 ### Active GiveWP Add-ons ### Give - Annual Receipts: ✔ Licensed – by GiveWP – 1.0.2 Give - Authorize.net Gateway: ✔ Licensed – by GiveWP – 1.4.6 Give - Braintree Gateway: ✔ Licensed – by GiveWP – 1.2.4 Give - CCAvenue Gateway: ✔ Licensed – by GiveWP – 1.0.4 Give - Constant Contact: ✔ Licensed – by GiveWP – 1.2.5 Give - Currency Switcher: ✔ Licensed – by GiveWP – 1.3.11 Give - Fee Recovery: ✔ Licensed – by GiveWP – 1.7.11 Give - Form Field Manager: ✔ Licensed – by GiveWP – 1.4.7 Give - Google Analytics Donation Tracking: ✔ Licensed – by GiveWP – 1.2.5 Give - MailChimp: ✔ Licensed – by GiveWP – 1.4.6 Give - Manual Donations: ✔ Licensed – by GiveWP – 1.4.6 Give - PayPal Pro Gateway: ✔ Licensed – by GiveWP – 1.2.2 Give - PDF Receipts: ✔ Licensed – by GiveWP – 2.3.10 Give - Per Form Gateways: ✔ Licensed – by GiveWP – 1.0.2 Give - Recurring Donations: ✔ Licensed – by GiveWP – 1.10.5 Give - Square: ✔ Licensed – by GiveWP – 1.1.1 Give - Stripe Gateway: ✔ Licensed – by GiveWP – 2.2.8 Give - Tributes: ✔ Licensed – by GiveWP – 1.5.7 Give - Zapier: ✔ Licensed – by GiveWP – 1.3.0 ### Other Active Plugins ### Email Cop: by Ashfame – 0.1.1 Google Analytics for WordPress by MonsterInsights: by MonsterInsights – 7.11.0 Plugin Detective - Troubleshooting: by N Squared – 1.1.6 ### Inactive Plugins ### Advanced CF7 DB: by Vsourz Digital – 1.7.2 Ben's Helper Functions: by BenUNC – Disable Gutenberg: by Jeff Starr – 2.1 Elementor: by Elementor.com – 2.9.13 Give - 2Checkout Gateway: by GiveWP – 1.1.4 Give - AmeriCloud Payments: by AmeriCloud Solutions, Inc. – 1.3.4 Give - Database HealthCheck: by WordImpress – 0.0.2 Give - Email Reports: by GiveWP – 1.1.4 Give - Form Countdown: by GiveWP – 1.0.1 Give - Mollie Gateway: by GiveWP – 1.2.4 Give - PayFast Payment Gateway: by WordImpress – 1.0.2 Give - Paytm Gateway: by GiveWP – 1.1.0 Hello Dolly: by Matt Mullenweg – 1.7.2 Loco Translate: by Tim Whitlock – 2.4.0 Page Builder by SiteOrigin: by SiteOrigin – 2.11.0 Query Monitor: by John Blackbourn – 3.6.0 Receipt Attachments for GiveWP: by GiveWP – 1.1.2 Shortcode in Menus: by Gagan Deep Singh – 3.5 Simple Social Shout for GiveWP: by Matt Cromwell – 1.0 SiteOrigin Widgets Bundle: by SiteOrigin – 1.17.0 Stop Donor Spam: by Matt Cromwell – 1.2.0 Tickera: by Tickera.com – 3.4.7.1 User Role Editor: by Vladimir Garagulya – 4.55.1 User Switching: by John Blackbourn & contributors – 1.5.5 Wordfence Security: by Wordfence – 7.4.9 WP Crontrol: by John Blackbourn & crontributors – 1.8.5 WP Rollback: by Impress.org – 1.7.0 ### Active MU Plugins ### api-hacks.php: by – helpr-mu.php: by – per-form-currency.php: by – ### Theme ### Name: Twenty Twenty Version: 1.4 Author URL: https://wordpress.org/ Child Theme: No – If you're modifying GiveWP on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

Acceptance Criteria

lindseymacmillan commented 4 years ago

I'm closing this issue in favor of one that has been opened in the Stripe plugin repository, since that is where the logic which introduced this bug actually exists. Ref: https://github.com/impress-org/give-stripe/issues/465