search

impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.
https://givewp.com/
GNU General Public License v3.0
340 stars 191 forks source link

Remove custom definition of array_column from includes/misc-functions.php #5253

Closed tw2113 closed 1 year ago

tw2113 commented 4 years ago

In short, array_column arrived in PHP 5.5. GiveWP currently requires PHP5.6. It should be safe to remove this custom definition at the moment for all future releases, and reduces the codebase volume safely

JasonTheAdams commented 4 years ago

Thanks for the suggestion, @tw2113! Just to be clear, is there any downside to leaving the shim apart from it likely being unnecessary? Just want to make sure you're not aware of it causing problems for someone in any way.

tw2113 commented 4 years ago

Nope, no technical issue with just leaving it, as it wouldn't be getting defined by the plugin, due to existing in PHP core already. More a housekeeping GH issue than anything :)

JasonTheAdams commented 4 years ago

Roger that! Thank you! 😄

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 14 additional days.

kjohnson commented 1 year ago

Closing this issue since /includes is now considered legacy code and is slated for deprecation and removal in the future.