impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.
https://givewp.com/
GNU General Public License v3.0
345 stars 191 forks source link

Uninstalling GiveWP should not throw an exception #5845

Closed JasonTheAdams closed 3 years ago

JasonTheAdams commented 3 years ago

User Story

As a WordPress user, I want uninstall GiveWP so that I can move on without it (probably sadly).

Details

Presently, uninstalling GiveWP on a fresh install throws an exception. The issue doesn't seem to occur when there are add-ons installed (not even activated). It's oddly niche, but it is easily reproducible.

Expected Behavior

GiveWP should simply uninstall without any final fighting words.

Steps to Reproduce

  1. Set up a fresh WP installation
  2. Install GiveWP from wp.org
  3. Go to the plugins screen
  4. Delete the GiveWP plugin
  5. See the error thrown.

Acceptance Criteria

canny[bot] commented 3 years ago

This issue has been linked to a Canny post: Uninstalling and deleting GiveWP should not cause fatal errors :tada: