Legacy Consumer: default values not used for multi-select

impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.

https://givewp.com/

GNU General Public License v3.0

345 stars 191 forks source link

Legacy Consumer: default values not used for multi-select #5951

Closed knowler closed 3 years ago

knowler commented 3 years ago

Details

I noticed that default values are not set in the select template when multiple is set to true. It needs to be able to set the default value for multiple options.

Acceptance Criteria

[x] Select template should set selected on <option> elements whose value corresponds to a value in the Select::$defaultValue array.

ravinderk commented 3 years ago

this has been fixed: https://github.com/impress-org/givewp/compare/abbe5ff369a2...919a525d79e0

knowler commented 3 years ago

Thank you, @ravinderk!