impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.
https://givewp.com/
GNU General Public License v3.0
345 stars 191 forks source link

Sourcemaps do not load correctly with Laravel Mix #6101

Closed DevinWalker closed 1 year ago

DevinWalker commented 2 years ago

User Story

As a developer, I want sourcemaps enabled so that I can easily find my way through the CSS to make changes.

Details

When I inspect elements I do not see the sourcemaps working and only see the minified CSS files in the dist directory.

As well, the README.md file now appears out-of-date and references SCRIPT_DEBUG which is no longer needed if Laravel Mix is implemented correctly:

2021-11-12_09-43-53

Expected Behavior

Sourcemaps work and the README is correct.

Steps to Reproduce

  1. Run npm run watch
  2. Go to frontend or admin
  3. Inspect a GiveWP element
  4. Notice the CSS is minified and you're not able to quickly find the location of the element for styling purposes

Visuals

The image below displays minified CSS when inspecting elements:

2021-11-12_09-46-41

Acceptance Criteria

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 14 additional days.

github-actions[bot] commented 1 year ago

This issue was closed because it has been stalled for an additional 14 days with no activity.