impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.
https://givewp.com/
GNU General Public License v3.0
340 stars 191 forks source link

Using the Donor Wall shortcode or block, while comments are enabled should not throw a PHP warning. #6477

Closed JoshuaHungDinh closed 2 years ago

JoshuaHungDinh commented 2 years ago

Details

In GiveWP version 2.21.0 give_donor_wall shows a PHP warning if comments are not disabled. With comments enabled, the PHP warning is shown and no comment is shown. Some sites are not showing the warning. Disabling debug in wp-config does not hide the warning.

Expected Behavior

Steps to Reproduce

Visuals

https://user-images.githubusercontent.com/75056371/174894208-9d9ec094-68bf-40b6-b683-8dfb8073ac30.mov

Acceptance Criteria

canny[bot] commented 2 years ago

This issue has been linked to a Canny post: In GiveWP version 2.21.0, using give_donor_wall shortcode or block, with comments not hidden, will throw a PHP warning. :tada: