search

impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.
https://givewp.com/
GNU General Public License v3.0
339 stars 191 forks source link

Wrong date when importing donations #6595

Open Genevieve-K opened 1 year ago

Genevieve-K commented 1 year ago

User Story

As a admin, I want to export donations and import them in a new site.

Details

The date of donation is sometimes wrong.

Steps to Reproduce

  1. In WP settings > General, choose the format d/m/Y ( 27/10/2022 )
  2. Export the donations
  3. In another site, import the donations
  4. Some donations have the today date, other are not visible because they are in the futur.
  5. The donations in the future gives an 400 error in some new functions: Value 'future' is not part of the enum Give\Donations\ValueObjects\DonationStatus.
  6. We cannot delete the donations in the future.

Raison

In import-functions.php, the date is defined by: $post_date = mysql2date( 'Y-m-d', $data['post_date'] ); However, the mysql2date() suppse that the imput format is m/d/Y if the separator is a slash. So '10/11/2022' becomes '11/10/2022' in the future. And '27/10/2022' is an unexisting date. I suggest to use the format selected in WP settings, with get_option('date_format').

I worked around by changing the settings before export the donations.

canny[bot] commented 1 year ago

This issue has been linked to a Canny post: Wrong date when importing donations :tada:

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 14 additional days. Note, if this Issue is reporting a bug, please reach out to our support at https://givewp.com/support. If this is a feature request, please see our feedback board at feedback.givewp.com — that’s the best place to make feature requests, unless you’re providing a PR.