Closed Benunc closed 8 years ago
break/wrapping issue can be fixed by making the width of that span "auto" instead of "125px"
I did not know so many nations use a space for large numbers. https://docs.oracle.com/cd/E19455-01/806-0169/overview-9/index.html
@ravinderk I assume Woo supports a space? If so, how does they do it?
@DevinWalker They store space in database for thousand separator if user want to and use this value in price formatting in number_format
function
https://github.com/woothemes/woocommerce/blob/master/includes/wc-formatting-functions.php#L419
This is resolved with https://github.com/WordImpress/Give/pull/734
@DevinWalker I found one issue if you check ben's screenshot you will see that if we set larger donation amount without having any custom donation then donation amount breaks in design.
Pull request to fix this issue : https://github.com/WordImpress/Give/pull/777
In many cultures/currencies, a space is used as the value separator for thousands. In order to enter a space in Give, users have to know the HTML entity code of
 
Can we create a way for that input to not sanitize out the space?
Further, once you use that in the settings field, it breaks the layout by wrapping the text on especially large donation amounts (which I realize is an edge case). This would be related to #693 and #650