search

impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.
https://givewp.com/
GNU General Public License v3.0
345 stars 191 forks source link

Avoid issues with CSS minification processes #7011

Closed fidoboy closed 11 months ago

fidoboy commented 1 year ago

The file names like eg, this one: baseFormDesignCss.css should be renamed to standard: baseFormDesignCss.min.css to skip external minification processes in WP cache plugins or Cloudflare. This file baseFormDesignCss.css gives errors if Cloudflare minify it again and it stops working. But it has no problems if the name is baseFormDesignCss.min.css because the .min into the name is universally recognized by almost all plugin and external code minificators. If there is a .min particle, the minificator script skips the file.

It shouldn't be difficult to solve, just adding .min to all filenames where CSS or JS code is already minified.

kjohnson commented 1 year ago

Hey @fidoboy, thanks for providing feedback.

To keep with the workflow to make sure that the right people see this feedback, I have migrated your feedback to https://feedback.givewp.com.

See https://feedback.givewp.com/feature-requests/p/avoid-issues-with-css-minification-processes

Please add yourself as a voter to help prioritize the feedback.

canny[bot] commented 1 year ago

This issue has been linked to a Canny post: Avoid issues with CSS minification processes :tada:

fidoboy commented 1 year ago

Hey @fidoboy, thanks for providing feedback.

To keep with the workflow to make sure that the right people see this feedback, I have migrated your feedback to https://feedback.givewp.com.

See https://feedback.givewp.com/feature-requests/p/avoid-issues-with-css-minification-processes

Please add yourself as a voter to help prioritize the feedback.

Thanks for adding it into the to-do list. I do not want to register myself as a voter, but any case this shouldn't be very difficult to accomplish. It's almost mandatory to follow the coding standards.

github-actions[bot] commented 11 months ago

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 14 additional days. Note, if this Issue is reporting a bug, please reach out to our support at https://givewp.com/support. If this is a feature request, please see our feedback board at feedback.givewp.com — that’s the best place to make feature requests, unless you’re providing a PR.

github-actions[bot] commented 11 months ago

This issue was closed because it has been stalled for an additional 14 days with no activity.