impress-org / givewp

GiveWP - The #1 Donation Plugin for WordPress. Easily accept donations and fundraise using your WordPress website.
https://givewp.com/
GNU General Public License v3.0
345 stars 191 forks source link

Strings in frontend iframe form are not being translated #7035

Closed fidoboy closed 1 year ago

fidoboy commented 1 year ago

In v3-rc8 the frontend form multi-step is displaying english strings untranslated but others are well.

JoshuaHungDinh commented 1 year ago

@fidoboy, Thank you for reporting this!

Our team is now aware of this matter, and it will be investigated by a developer. We'll keep you updated on the progress. If you encounter any further issues or have additional information to share, please don't hesitate to let us know. Your feedback is appreciated.

JasonTheAdams commented 1 year ago

Hi @fidoboy!

Just wanted to give you a heads up that we just merged https://github.com/impress-org/givewp/pull/7039

This will be included in the upcoming 3.0 release!

fidoboy commented 1 year ago

Hi @JasonTheAdams I've just downloaded the new rc9 and strings are still not being translated.

glaubersilva commented 1 year ago

Hi @fidoboy

Can you provide some samples of strings not being translated?

fidoboy commented 1 year ago

Hi @fidoboy

Can you provide some samples of strings not being translated?

In multi step iframe the words: raised, goal, secure transaction, amount, donation amount, etc. Many of them.

fidoboy commented 1 year ago

Hi @fidoboy

Can you provide some samples of strings not being translated?

@glaubersilva This is captured today, using GiveWP 3.0 final version. As you can notice there are untranslated strings in multi step form in frontend.

Captura1

Captura2

Captura3

glaubersilva commented 1 year ago

@fidoboy After investigating it further, we realized that the new strings are present in the source file (give.pot) shipped with the plugin. However, the translation files (*.po) from wp.org that you can download from the WordPress updates page are not getting updated with these new strings. We have a developer working on it, but it can take time to figure out why these strings aren't synced.

In this means time, you can download the Loco Translate plugin and use the sync feature to add the new strings from the source file (give.pot) in the translation file (*.po) of your language - check the attached screenshots for visual references about how to do it.

After adding/syncing the new strings to your language file (*.po) you can use the Loco translate UI to translate the new strings. Let me know if you have any more questions. =)

sync-1

sync-2

fidoboy commented 1 year ago

@fidoboy After investigating it further, we realized that the new strings are present in the source file (give.pot) shipped with the plugin. However, the translation files (*.po) from wp.org that you can download from the WordPress updates page are not getting updated with these new strings. We have a developer working on it, but it can take time to figure out why these strings aren't synced.

In this means time, you can download the Loco Translate plugin and use the sync feature to add the new strings from the source file (give.pot) in the translation file (*.po) of your language - check the attached screenshots for visual references about how to do it.

After adding/syncing the new strings to your language file (*.po) you can use the Loco translate UI to translate the new strings. Let me know if you have any more questions. =)

sync-1

sync-2

Thanks a lot for all that detailed information. I already did it that way to solve the issue and it's partially working, but even using loco translate there is some strings that can't be translated.

glaubersilva commented 1 year ago

Hi @fidoboy

Glad to know my last reply was useful. About the other strings, I noticed that you highlighted in your screenshots some texts related to placeholders, labels, and section titles/descriptions. These strings/texts can be customized directly in the Form Builder as you can check in the attached screenshot.

image

fidoboy commented 1 year ago

Hi @fidoboy

Glad to know my last reply was useful. About the other strings, I noticed that you highlighted in your screenshots some texts related to placeholders, labels, and section titles/descriptions. These strings/texts can be customized directly in the Form Builder as you can check in the attached screenshot.

image

Thanks again. I've noticed that some strings can be translated from the editor also. However it could be nice if they was already translated by default from the begining to avoid end user confusions.

Also I can't find a way to translate the string being displayed when a field if left empty or it has a wrong value in frontend form. And the string "Or pay with credit card", "Cardholder name" and "MM/YYYY" can't be translated in frontend.

glaubersilva commented 1 year ago

Thanks for the feedback @fidoboy

About these points:

However it could be nice if they was already translated by default from the begining to avoid end user confusions.

Also I can't find a way to translate the string being displayed when a field if left empty or it has a wrong value in frontend form. And the string "Or pay with credit card", "Cardholder name" and "MM/YYYY" can't be translated in frontend.

We are working to make the translations for these strings be possible in the next Give version.