impress-org / google-maps-builder

One Google Maps plugin to rule them all. Google Maps Builder is intuitive, sleek, powerful and easy to use. Forget the rest, use the best.
https://wordpress.org/plugins/google-maps-builder/
32 stars 9 forks source link

Add a private constructor to Google_Maps_Builder class ? #141

Closed Shelob9 closed 8 years ago

Shelob9 commented 8 years ago

Question for @DevinWalker Google_Maps_Builder class uses an almost singleton pattern, but has no __construct() magic method, so I can make a new instance of it at any time. The class totally should be a singleton, you wouldn't want anything there besides instance() to run twice. So, shouldn't we make it a true singleton by preventing new instances from being instantiated? I can't see any harm here, but I could be missing something...

Shelob9 commented 8 years ago

Fixed in core