search

impress-org / google-maps-builder

One Google Maps plugin to rule them all. Google Maps Builder is intuitive, sleek, powerful and easy to use. Forget the rest, use the best.
https://wordpress.org/plugins/google-maps-builder/
32 stars 9 forks source link

Create Marker modal needs overflow: hidden #202

Closed kevinwhoffman closed 8 years ago

kevinwhoffman commented 8 years ago

The Create Marker modal window background does not fill the entire container. Here is the CSS to fix it:

.magnific-builder #poststuff .white-popup .inner-modal-wrap .inner-modal {
    overflow: hidden;
}

Before overflow: hidden create-marker-before-overflow

After overflow: hidden create-marker-after-overflow

DevinWalker commented 8 years ago

Overflow hidden doesn't make the location dropdown disappear? How about adding a clearfix class to the modal container?

kevinwhoffman commented 8 years ago

There is already a clearfix class on the container but it doesn't seem to be doing anything. I don't remember seeing this visual bug in previous versions, so maybe something changed in 2.0.2.

Here's the change I made that fixed it for me. Note the clearfix class is already on the element where I've added overflow: hidden. create-marker-dev-tools

And to answer your question, the dropdown still overflows outside of the container just fine because it is outside of the element and absolutely positioned.

kevinwhoffman commented 8 years ago

Screenshot of dropdown still visible after overflow: hidden: create-marker-dropdown

DevinWalker commented 8 years ago

This is fixed