search

impress-org / google-maps-builder

One Google Maps plugin to rule them all. Google Maps Builder is intuitive, sleek, powerful and easy to use. Forget the rest, use the best.
https://wordpress.org/plugins/google-maps-builder/
32 stars 9 forks source link

Signed-In feature being retired in Google API #231

Closed sstruemph closed 7 years ago

sstruemph commented 7 years ago

I noticed this message today in the console:

Google Maps API warning: SignedInDeprecated

And according to the Google Docs:
"The signed_in parameter is deprecated and will be ignored in future versions of the Google Maps JavaScript API. It won't prevent the Google Maps JavaScript API from working after signed-in mode has retired, but the behavior of your application may change, if you rely on current signed-in features.

Please review your application and see Signed-in Maps | Google Maps JavaScript API for details about the upcoming changes."

We might need to consider removing that from the plugin if it's going away.

mathetos commented 7 years ago

Yes, this needs to be removed completely: https://developers.google.com/maps/documentation/javascript/signedin

It's causing issues with users.

kevinwhoffman commented 7 years ago

As of 2.1.2, this setting will be removed. For backwards compatibility, any parameters that reference the setting will be deprecated by changing those parameters to $deprecated and updating the function's DocBlock.