Closed mathetos closed 7 years ago
Hi Matt,
thanks for creating that issue for me. Just two things I wanna mention:
/vendor/wordimpress/maps-builder-core/assets/js/frontend/google-maps-builder.js
affects the core version. The other 3 changes only affect the pro version.If anyone has questions about the added hooks or why I needed them, just drop me a message here.
@TobiasMalikowski I wanted to give you a heads up that your recommended filters and triggers will be added in version 2.1.2. Please note the names might be slightly different than what you provided because we had to ensure they were prefixed. The full list is below for your reference.
gmb.initialize_map
JS trigger - Coregmb.set_mashup_marker
JS trigger - Progmb_mashup_builder_fields
filter - Progmb_get_mashup_markers_callback
filter - Pro@kevinwhoffman Great to hear that! Thanks for the integration. I'll check this out when it's released.
A customer was extremely diligent in going through and adding hooks into our plugin for their own purposes.
Here's lines and updates directly from the work they did. NOTE: All lines are referenced from the compiled PRO plugin:
/assets/js/frontend/google-maps-builder.js
-> Line 140 -> gmb.set_mashup_marker/vendor/wordimpress/maps-builder-core/assets/js/frontend/google-maps-builder.js
-> Line 135 -> gmb.set_mashup_marker/includes/admin/mashups/class-gmb-mashups-builder.php
-> Line 210 -> mashup_builder_fields/includes/admin/mashups/class-gmb-mashups-builder.php
-> Line 572 -> get_mashup_markers_callbackHere's the customer issue: https://secure.helpscout.net/conversation/365591409/7658/?folderId=672193