impress-org / google-maps-builder

One Google Maps plugin to rule them all. Google Maps Builder is intuitive, sleek, powerful and easy to use. Forget the rest, use the best.
https://wordpress.org/plugins/google-maps-builder/
32 stars 9 forks source link

Add hooks to make it more extensible #249

Closed mathetos closed 7 years ago

mathetos commented 7 years ago

A customer was extremely diligent in going through and adding hooks into our plugin for their own purposes.

Here's lines and updates directly from the work they did. NOTE: All lines are referenced from the compiled PRO plugin:

/assets/js/frontend/google-maps-builder.js -> Line 140 -> gmb.set_mashup_marker

/vendor/wordimpress/maps-builder-core/assets/js/frontend/google-maps-builder.js -> Line 135 -> gmb.set_mashup_marker

/includes/admin/mashups/class-gmb-mashups-builder.php -> Line 210 -> mashup_builder_fields

/includes/admin/mashups/class-gmb-mashups-builder.php -> Line 572 -> get_mashup_markers_callback

Here's the customer issue: https://secure.helpscout.net/conversation/365591409/7658/?folderId=672193

MALIK-0 commented 7 years ago

Hi Matt,

thanks for creating that issue for me. Just two things I wanna mention:

  1. I suppose the dev team can view the edited files on the link you provided?
  2. The label only pro version is not 100 % correct, as the change in /vendor/wordimpress/maps-builder-core/assets/js/frontend/google-maps-builder.js affects the core version. The other 3 changes only affect the pro version.

If anyone has questions about the added hooks or why I needed them, just drop me a message here.

kevinwhoffman commented 7 years ago

@TobiasMalikowski I wanted to give you a heads up that your recommended filters and triggers will be added in version 2.1.2. Please note the names might be slightly different than what you provided because we had to ensure they were prefixed. The full list is below for your reference.

MALIK-0 commented 7 years ago

@kevinwhoffman Great to hear that! Thanks for the integration. I'll check this out when it's released.