search

impress-org / google-maps-builder

One Google Maps plugin to rule them all. Google Maps Builder is intuitive, sleek, powerful and easy to use. Forget the rest, use the best.
https://wordpress.org/plugins/google-maps-builder/
32 stars 9 forks source link

Multi-Form Goal Shortcode ids parameter breaks editor in GiveWP 3.0 #286

Open canny[bot] opened 10 months ago

canny[bot] commented 10 months ago

The "ids" parameter within the Multi-Form Goal Shortcode disrupts the editor in GiveWP 3.0. Saving the page where the shortcode is placed appears to fail, but reloading the editor results in a PHP warning and an inability to edit the page.

Warning: _give_redirect_form_id(): Argument #1 ($formId) must be passed by reference, value given in .../wp-content/plugins/give/src/MultiFormGoals/MultiFormGoal/Shortcode.php on line 52

https://givewp.canny.io/admin/board/bug-reports/p/multi-form-goal-shortcode-ids-parameter-breaks-editor-in-givewp-30

canny[bot] commented 10 months ago

This issue has been linked to a Canny post: Multi-Form Goal Shortcode ids parameter breaks editor in GiveWP 3.0 :tada:

canny[bot] commented 10 months ago

This issue has been unlinked from a Canny post: Multi-Form Goal Shortcode ids parameter breaks editor in GiveWP 3.0 :cry:

glaubersilva commented 10 months ago

This issue should not be considered as it was created in the wrong repository. The right one is this: https://github.com/impress-org/givewp/issues/7060