Closed janishutz closed 1 year ago
I have now also removed the getting started guide from this PR
Should be fixed now
Let's ignore that I just removed one too many lines
Okay so there are notes in this presentation, and they seem to work. Can you confirm?
Yeah it is hidden from the CSS file. I felt like it should be hidden from JS.
This is another thing that should be in impress-common.css. But definitely CSS, not JS.
I agree with @henrikingo here. In particular, adding display: none
directly to the element's style makes it unnecessarily hard in case you actually want to show notes. For instance, what I really like about Google's io-2012-slides is that they allow you not only to see the presenter notes in the presenter mode, but also by pressing the hotkey 'P' anywhere in the presentation. See for instance this example and press 'P'. However, this would require a display: block !important
when hiding is done by JavaScript instead of just using CSS.
I see that, I'll close the PR
I noticed that notes are not hidden properly all the time. I have read through the source code and have actually not found any code that would hide the notes.