search

impress / impress.js

It's a presentation framework based on the power of CSS3 transforms and transitions in modern browsers and inspired by the idea behind prezi.com.
http://impress.js.org
MIT License
37.62k stars 6.67k forks source link

Bugfix for notes not being hidden reliably #834

Closed janishutz closed 1 year ago

janishutz commented 1 year ago

I noticed that notes are not hidden properly all the time. I have read through the source code and have actually not found any code that would hide the notes.

janishutz commented 1 year ago

I have now also removed the getting started guide from this PR

janishutz commented 1 year ago

Should be fixed now

janishutz commented 1 year ago

Let's ignore that I just removed one too many lines

henrikingo commented 1 year ago

Okay so there are notes in this presentation, and they seem to work. Can you confirm?

https://impress.js.org/examples/classic-slides/

janishutz commented 1 year ago

Yeah it is hidden from the CSS file. I felt like it should be hidden from JS.

henrikingo commented 1 year ago

This is another thing that should be in impress-common.css. But definitely CSS, not JS.

fnogatz commented 1 year ago

I agree with @henrikingo here. In particular, adding display: none directly to the element's style makes it unnecessarily hard in case you actually want to show notes. For instance, what I really like about Google's io-2012-slides is that they allow you not only to see the presenter notes in the presenter mode, but also by pressing the hotkey 'P' anywhere in the presentation. See for instance this example and press 'P'. However, this would require a display: block !important when hiding is done by JavaScript instead of just using CSS.

janishutz commented 1 year ago

I see that, I'll close the PR