search

impress / impress.js

It's a presentation framework based on the power of CSS3 transforms and transitions in modern browsers and inspired by the idea behind prezi.com.
http://impress.js.org
MIT License
37.62k stars 6.67k forks source link

fallback-message hiding moved to impress-common CSS file #840

Closed janishutz closed 1 year ago

janishutz commented 1 year ago

I’m not home yet, but did the changes rq anyway. Will also close the issue. If anybody else has any suggestions, let me know

janishutz commented 1 year ago

I also had the suggestion to hide the fallback-message class from js. I could add that one if you’d like.

fnogatz commented 1 year ago

Gosh, what happened here at all? :laughing:

Screenshot from 2022-12-14 18-29-09

Though we could manage to stack all these commits – @simplePCBuilding, I would suggest you just start from a fresh version of the master branch and apply the required changes, and use this for a new pull request. These 22 commits in-between make it unnecessarily hard to review the changes.

janishutz commented 1 year ago

Right. I kinda messed up there because I have not really worked with pull requests before

fnogatz commented 1 year ago

Then it's a good time to give it a second, fresh try? :)

janishutz commented 1 year ago

I'm removing all the commits from master and reopening the PR

janishutz commented 1 year ago

how do I reset my master branch?

henrikingo commented 1 year ago

I also had the suggestion to hide the fallback-message class from js. I could add that one if you’d like.

No, using CSS is correct. The fallback message is content. It may or may not exist, and user may use whatever HTML and CSS class around it.

Everything under impress-common.css is optional, while impress.js is of course not. (Although you could rebuild your own and leave out some plugins.) So as much as possible should be HTML+CSS because that leaves the end user the choice to do whatever they want.

fnogatz commented 1 year ago

how do I reset my master branch?

Hey @simplePCBuilding, you could jump back to the latest commit of the original impress/impress.js repository, and create a new branch from that. Something like this:

cd your-local-repository
git checkout master
git checkout 64d66bf77feda50c6dcdf4d01bf5ef22a79e4df4 # this is the last commit your and the original impress/impress.js respositories have in common
git remote add upstream git@github.com:impress/impress.js.git # add the original impress/impress.js repository as upstream
git pull upstream master # pull latest changes from the original impress/impress.js repository
git checkout -b 840-move-fallback-message-css # create a new branch
# perform your changes and go on with git add + commit + push
janishutz commented 1 year ago

That didn't work.... It says it couldn't read from remote repo... yikes. Anyway. If we could merge the GettingStarted guide, I'd anyway have a clean master branch again. All this mess was caused due to me being new to PRs

janishutz commented 1 year ago

I will, once I have a clean master branch again, reopen this PR. I was not willing to delete my fork because I had already done a lot of work when it comes to the website, so I will just delete this branch sooner or later.