Closed mengwong closed 10 months ago
i will make the linter happy
You still have double quotes in the code that's why it complains. Please run
npm run all
before pushing
You know, the weird thing that's going on, is that both my PRs, which are generally unrelated, both are failing tests in similar ways … maybe a curse is following me around
if I could get this to run after init, the step-N
ids would be allocated, and I wouldn't have to worry about divs not having ids.
so, I did run npm run all
before submitting the PR, and it turns out that fixing the linter errors was what led to the test failures. Everything is fine at 2c43ff3 😄
ah, null !== undefined
JS is the best language EVAR
> null != undefined
false
> null !== undefined
true
Fun fact, this is actually one of my most favourite (and at the same time most hated) features of js
Thanks for helping me get this PR shipshape, I appreciate it. I am building an app involving this codebase and will keep an eye out for problems. If there are no problems I will follow up in a while and maybe we can have another think about integrating this into master.
Okay, great! Can you post a link to your project here, if it's open source?
Okay, great! Can you post a link to your project here, if it's open source?
I will … once it is more presentable … still trying to figure out a bunch of things.
resolves https://github.com/impress/impress.js/issues/850