Fix default substep order when no explicit order given (#855)

impress / impress.js

It's a presentation framework based on the power of CSS3 transforms and transitions in modern browsers and inspired by the idea behind prezi.com.

http://impress.js.org

MIT License

37.62k stars 6.67k forks source link

Fix default substep order when no explicit order given (#855) #856

Closed treitmayr closed 9 months ago

treitmayr commented 1 year ago

This PR fixes the default order of substeps, for which no explicit order was given (see issue #855). It ensures that the loop for marking substeps "active" + "visible" is left when at least one substep (with explicit or default order) was marked and this substep uses default order.

Note: The removed space in the header of js/impress.js does not relate to the current issue, but comes from regenerating this file. Apparently the file has not been regenerated when its source file was modified in some previous commit.

treitmayr commented 1 year ago

I had to update the PR because I realized that not only going to the next substep was broken, but also going to the previous one. Should work now.

fnogatz commented 1 year ago

Thank you, @treitmayr, for your contribution! Indeed, this was a bug in the substep plugin. I have not looked in detail into its history, but maybe it was introduced by my modifications in https://github.com/impress/impress.js/pull/825 :see_no_evil:

I tested your modifications and they work as expected, thank you! @henrikingo, this is good to merge :)