search

impresspages / ImpressPages

ImpressPages is php framework with admin panel. Build functional website in one hour.
http://www.impresspages.org
Other
501 stars 178 forks source link

Major bug: Invalid default value for 'lockedAt' #777

Closed XEuRoMAN closed 8 years ago

XEuRoMAN commented 8 years ago

I can't install IP and error is showing completely unrelated error in view of true bug.

error

So, that thing confused me for some time but I noticed that there is missing a lot of tables in the DB... Real problem is that ip_email_queue table is using wrong default value for lockedAt field.

mysql_error

According to the MySQL documentation: http://dev.mysql.com/doc/refman/5.7/en/datetime.html valid range for timestamp is between

'1970-01-01 00:00:01' UTC to '2038-01-19 03:14:07' UTC

I'm using latest MySQL 5.7.9 (on Windows 10), so maybe in previous versions it was warning or something but now it's error which is blocking table creation process (and that error is not showing in the IP).

I'm not doing pull request with the fix of this bug because maybe there is other stuff about ip_email_queue table which is related with current default value.

maskas commented 8 years ago

I guess it would be the best to change that field from "not null" to "null" with default value "null".