search

impresspages / ImpressPages

ImpressPages is php framework with admin panel. Build functional website in one hour.
http://www.impresspages.org
Other
501 stars 175 forks source link

Unreachable code in RepositoryFile grid field #796

Closed XEuRoMAN closed 8 years ago

XEuRoMAN commented 8 years ago

I'm making plugin of my custom field and noticed that there is some unreachable code in CMS core.

https://github.com/impresspages/ImpressPages/blob/ea121628e03f2a3b0d5764ac1c74427a65422197/Ip/Internal/Grid/Model/Field/RepositoryFile.php#L77

every code is in isset closure but inside this closure someone expecting that this value won't be set. https://github.com/impresspages/ImpressPages/blob/ea121628e03f2a3b0d5764ac1c74427a65422197/Ip/Internal/Grid/Model/Field/RepositoryFile.php#L79 https://github.com/impresspages/ImpressPages/blob/ea121628e03f2a3b0d5764ac1c74427a65422197/Ip/Internal/Grid/Model/Field/RepositoryFile.php#L85

maskas commented 8 years ago

Cool?

XEuRoMAN commented 8 years ago

Cool.