search

impresspages / ImpressPages

ImpressPages is php framework with admin panel. Build functional website in one hour.
http://www.impresspages.org
Other
501 stars 178 forks source link

Using a .navbar class in a theme potentially breaks the admin space. #803

Open jvlaar opened 7 years ago

jvlaar commented 7 years ago

Using a few commonly used selectors, such as .navbar for example can alter or break the admin styling. My suggestion would be to prefix all the CMS classes with something like .admin_, so ._admin_navbar for example.

jankus commented 7 years ago

Leaving exposed default Bootstrap selectors was a architectural mistake. We did that for optimization. We wrapped it under .ip scope. Normally this is enough because it creates a bigger specificity compared to default Bootstrap selectors in the theme. Nevertheless, we do know that on some cases this still causes some problems.

Since you develop a theme and you know exact selectors, you can add reverted fixes for admin part look good again. I know it's not convenient but a working solution.