switch from MyISAM to InnoDB

impresspages / ImpressPages

ImpressPages is php framework with admin panel. Build functional website in one hour.

http://www.impresspages.org

Other

501 stars 179 forks source link

switch from MyISAM to InnoDB #849

Closed Remo closed 7 years ago

Remo commented 7 years ago

MyISAM is pretty limited, can't see any reason why InnoDB shouldn't be the default storage engine.

maskas commented 7 years ago

I don't know how it is at the moment. But earlier not all hosting providers allowed InnoDB. I'm a little scared to merge this pull request.

Remo commented 7 years ago

Pretty sure that's a thing of the past, these days every CMS/framework I came across uses InnoDB. MySQL 5.6 even supports fulltext indexes, that's probably the only benefit it had. InnoDB would also make it possible to add foreign keys at some points, making sure we don't have any issues with referential integrity.

maskas commented 7 years ago

I've just merged, but now I see, that those who update, will still have MyISAM, while those, who make a fresh install, will have InnoDB. It would be good to have a migration to make sure all websites are in sync.

Remo commented 7 years ago

Yes, indeed! I haven't done any research regarding the way you handle migrations. Feel free to open this, maybe I've got time in the future, but can't promise anything.