Intermittent issues with images not showing in repository

[TonyWasp]

Sometimes they show others the empty.gif is called. It's not all the time. It's not cos images are too big either it can happen with small icons. Any ideas on how to fix this would be appreciated.

Thanks

[jankus]

Can you reproduce it every time? Or is it random? Have you tracked what kind of images are failing? Maybe file type is an issue?

[TonyWasp]

It's random. It doesn't matter if it's gif, jpg or png.

[TonyWasp]

Thought it might be the custom theme, but just installed a version with the default air theme and it still happens.

[azanov]

Can you try to resize or scroll the window? Do the images re-appear in this case?

[TonyWasp]

Yeah, that doesn't work.

[azanov]

Can you try opening the developer tools in your browser and check if there are any errors in the console? Also check the network tab to see the server response for the failed requests.

[TonyWasp]

Yep, no errors

[TonyWasp]

This is still an issue. Client now testing and they can't see any images in repository.

[TonyWasp]

[TonyWasp]

Not sure why the screen shot captured multiple pages?

[TonyWasp]

Hold on. Think this might be a clue. If I resize the browser then scroll down they appear?

[jankus]

It could be some custom plugin or external JavaScript library that breaks this. Try on completely fresh installation. ImpressPages prints all images at once. Inspect the difference between elements that show image and those that don't. There must be some clue, errors, empty values etc. Check AJAX response from the server. Do all images get all data? Can you copy/paste their path in the browser and do they show up?

[azanov]

@jankus: The latest repository has lazy loading enabled. Only visible images are loaded. @TonyWasp: Can you tell me which browser you are using and what the exact version of it is?

[TonyWasp]

Chrome latest build (Version 62.0.3202.94)

[TonyWasp]

I tried a clean install, still got the problem. The images did exist when I copied the path.

[azanov]

I could not reproduce the issue with the latest Chrome. I think it makes sense if I can have a closer look at the issue through TeamViewer. Just add me on Skype (pavel_azanov), so we can set up a session some time.

Temporarily I can suggest you to edit this function in your installation to always return true:

https://github.com/impresspages/ImpressPages/blob/master/Ip/Internal/Repository/assets/ipRepositoryAll.js#L82

Change

_isVisible: function (element) {
    var $browser = $('.ipsBrowser'),
        $element = $(element),
        scrollTop = $browser.scrollTop(),
        elementY = $element.offset().top;
    return ((elementY < ($browser.height() + scrollTop)) && (elementY > (scrollTop - $element.height())));
},

to

_isVisible: function (element) {
    return true;
},

[TonyWasp]

Thanks I'll try it and let you know.

[koos91]

I have the same problem but I think the problem exist because the lazyload is only triggered when the vertical scrollbar for the website itself is at top-position.

When you open the repository you can see two vertical scrollbars, one for the repository and on for the website (when website-height is larger than the viewport). The images inside the repository only appears when the scrollbar of the website is (almost) at the top and you scroll inside the repository.

To reproduce

• [ ] Be sure of a repository with some uploaded images

• [ ] Create a page with enough (dummy)content to have a pretty large vertical scrollbar

• [ ] Place a image-widget at the bottom of the page

• [ ] You will see the repository filled with empy.gif "images"

• [ ] When you scroll inside the repository only, no images will be shown

• [ ] Set the scrollposition of the website to the top (second scrollbar)

• [ ] Still no images are shown, but...

• [ ] If you scroll again inside the repository itself, images will been shown

Tested in Firefox 57.0.2 and Chrome 63.0.3239.84

[azanov]

@koos91 Thanks for testing! I could reproduce the issue and will make a fix

[azanov]

Update is prepared, waiting for it to be included in the latest code

[pointtom]

I am having the same image problem. I seem to old get a few images loaded. On 1st entry I get no images showing at all. If I then scroll I get some only.

[azanov]

@pointtom There's a fix (https://github.com/impresspages/ImpressPages/pull/872) for this bug already, waiting for the PR to be accepted.

[pointtom]

Excellent thanks for that. I do like the CMS. Have integrated my weeWX weather station into it also a webcam.

[pointtom]

@azanov I have made the changes as a tempory fix and all so far is looking good. Thanks for that.