Here is Patch: php 7 Error: "assert(): Calling assert() with a string argument is deprecated in /Ip/Internal/Revision.php:44"

impresspages / ImpressPages

ImpressPages is php framework with admin panel. Build functional website in one hour.

http://www.impresspages.org

Other

502 stars 175 forks source link

Here is Patch: php 7 Error: "assert(): Calling assert() with a string argument is deprecated in /Ip/Internal/Revision.php:44" #885

Open johnyradio opened 6 years ago

johnyradio commented 6 years ago

fix below

johnyradio commented 6 years ago

Here's the fix.

Change line 44, from: assert('$pageId > 0'); to assert($pageId > 0);

Can someone patch the app? I can try. Would be my first patch ever :D

jankus commented 6 years ago

PHP decided to deprecate some default PHP functions and now is throwing notices. In production mode such messages shouldn't appear. It's only for an informational purpose.

Your options:

set 'developmentEnvironment' and 'showErrors' to "0" in config.php
downgrade PHP to the latest stable PHP7.1
hide notices with PHP configuration

johnyradio commented 6 years ago

@jankus what's wrong with the patch i offered, above? It fixes the bug.

jankus commented 6 years ago

There's nothing wrong =] It needs changing the core files. And not everyone can access them or feels comfortable by doing that.

If you tested the fix thoroughly, please create a Pull Request. And with the next release it will go out for everyone.

johnyradio commented 6 years ago

Thx! Tho', I think deleting 2 characters from the core file is the simplest, least effort. Also, downgrading php seems undesirable.

ImpressPages rocks!

Iwork4beer commented 4 years ago

The same change is needed in line 75.