search

improbable-eng / ansible-buildkite-agent

An Ansible role to install the Buildkite Agent.
Apache License 2.0
12 stars 14 forks source link

Fix user-password handling on Windows #56

Closed petemounce closed 4 years ago

petemounce commented 4 years ago

Changes

Revert a change (ability to supply password, introduced in e1d9460 while fixing lint :-( ) that caused an internal regression; bump major version in case anyone was relying on that new-and-now-removed behaviour.

Allow the binary installation choice to be feature-flagged per platform.

Non-functional change to ternary logic in one when.

Verification

improbable-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DoomGerbil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/improbable-eng/ansible-buildkite-agent/blob/develop/OWNERS)~~ [DoomGerbil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment